From 33ad5eb85bdc26f7857207549661ececaaf11588 Mon Sep 17 00:00:00 2001 From: Nic Ma Date: Thu, 23 Dec 2021 22:39:10 +0800 Subject: [PATCH 1/2] [DLMED] remove warning Signed-off-by: Nic Ma --- monai/engines/workflow.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/monai/engines/workflow.py b/monai/engines/workflow.py index 9c1b1719a4..f7cc19bb81 100644 --- a/monai/engines/workflow.py +++ b/monai/engines/workflow.py @@ -20,7 +20,7 @@ from monai.config import IgniteInfo from monai.engines.utils import IterationEvents, default_metric_cmp_fn, default_prepare_batch -from monai.transforms import Decollated, Transform +from monai.transforms import Decollated from monai.utils import ensure_tuple, is_scalar, min_version, optional_import from .utils import engine_apply_transform @@ -186,8 +186,7 @@ def set_sampler_epoch(engine: Engine): self._register_decollate() if postprocessing is not None: - if not decollate and isinstance(postprocessing, Transform): - warnings.warn("MONAI transforms expect `channel-first` data, `decollate=False` may not work here.") + # tips: MONAI transforms expect `channel-first` data, if `decollate=False`, may not work here self._register_postprocessing(postprocessing) if key_metric is not None: self._register_metrics(key_metric, additional_metrics) From 33d868c1116c8f79e4ebd7ffa1fa86aee766d22e Mon Sep 17 00:00:00 2001 From: Nic Ma Date: Fri, 24 Dec 2021 07:30:00 +0800 Subject: [PATCH 2/2] [DLMED] fix typo Signed-off-by: Nic Ma --- monai/engines/workflow.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monai/engines/workflow.py b/monai/engines/workflow.py index f7cc19bb81..4222db0593 100644 --- a/monai/engines/workflow.py +++ b/monai/engines/workflow.py @@ -186,7 +186,8 @@ def set_sampler_epoch(engine: Engine): self._register_decollate() if postprocessing is not None: - # tips: MONAI transforms expect `channel-first` data, if `decollate=False`, may not work here + # tips: if `decollate=False` and `postprocessing` is MONAI transforms, it may not work well + # because all the MONAI transforms expect `channel-first` data self._register_postprocessing(postprocessing) if key_metric is not None: self._register_metrics(key_metric, additional_metrics)