From af83ef7f718b1500e11baca46458399a0e0089bd Mon Sep 17 00:00:00 2001 From: Yiheng Wang Date: Mon, 26 Dec 2022 13:02:32 +0800 Subject: [PATCH 1/3] fix issue on windows Signed-off-by: Yiheng Wang --- monai/bundle/scripts.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monai/bundle/scripts.py b/monai/bundle/scripts.py index b625578049..4b3e587ffe 100644 --- a/monai/bundle/scripts.py +++ b/monai/bundle/scripts.py @@ -182,7 +182,7 @@ def _get_latest_bundle_version(source: str, name: str, repo: str): return None elif source == "github": repo_owner, repo_name, tag_name = repo.split("/") - return get_bundle_versions(name, repo=os.path.join(repo_owner, repo_name), tag=tag_name)["latest_version"] + return get_bundle_versions(name, repo=f"{repo_owner}/{repo_name}", tag=tag_name)["latest_version"] else: raise ValueError(f"To get the latest bundle version, source should be 'github' or 'ngc', got {source}.") From e15e47e7302b01283fd0a3e9aa7515577e1f4bfa Mon Sep 17 00:00:00 2001 From: Yiheng Wang Date: Fri, 30 Dec 2022 14:13:13 +0800 Subject: [PATCH 2/3] remove skip windows Signed-off-by: Yiheng Wang --- tests/test_bundle_download.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/test_bundle_download.py b/tests/test_bundle_download.py index 09cd0128f9..be1e82724b 100644 --- a/tests/test_bundle_download.py +++ b/tests/test_bundle_download.py @@ -58,7 +58,6 @@ ] -@skip_if_windows class TestDownload(unittest.TestCase): @parameterized.expand([TEST_CASE_1, TEST_CASE_2]) @skip_if_quick From ff6df9043d1d0daf349d9d67632fa3191a70484f Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 30 Dec 2022 06:13:46 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- tests/test_bundle_download.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/test_bundle_download.py b/tests/test_bundle_download.py index be1e82724b..12f15d3b41 100644 --- a/tests/test_bundle_download.py +++ b/tests/test_bundle_download.py @@ -26,7 +26,6 @@ command_line_tests, skip_if_downloading_fails, skip_if_quick, - skip_if_windows, ) TEST_CASE_1 = ["test_bundle", None]