From 2747ce09f651ecc42578b356d9b90d020ea2ff6b Mon Sep 17 00:00:00 2001 From: Indra Tjhai Date: Thu, 24 Feb 2022 09:28:45 -0500 Subject: [PATCH 1/2] QZ-721 Enable noUncheckedIndexedAccess tsc flag --- package-lock.json | 6 +++--- package.json | 2 +- src/components/ResponsiveImage/ResponsiveImage.tsx | 2 +- tsconfig.json | 3 ++- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/package-lock.json b/package-lock.json index fec5a00d..1553832b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18908,9 +18908,9 @@ } }, "typescript": { - "version": "4.0.3", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.0.3.tgz", - "integrity": "sha512-tEu6DGxGgRJPb/mVPIZ48e69xCn2yRmCgYmDugAVwmJ6o+0u1RI18eO7E7WBTLYLaEVVOhwQmcdhQHweux/WPg==", + "version": "4.5.5", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.5.5.tgz", + "integrity": "sha512-TCTIul70LyWe6IJWT8QSYeA54WQe8EjQFU4wY52Fasj5UKx88LNYKCgBEHcOMOrFF1rKGbD8v/xcNWVUq9SymA==", "dev": true }, "unfetch": { diff --git a/package.json b/package.json index 3efbd2d3..44304c17 100644 --- a/package.json +++ b/package.json @@ -59,6 +59,6 @@ "sass-loader": "^10.1.0", "style-loader": "^2.0.0", "stylelint": "^13.6.1", - "typescript": "^4.0.3" + "typescript": "^4.5.5" } } diff --git a/src/components/ResponsiveImage/ResponsiveImage.tsx b/src/components/ResponsiveImage/ResponsiveImage.tsx index f8be87e1..1ca0449a 100644 --- a/src/components/ResponsiveImage/ResponsiveImage.tsx +++ b/src/components/ResponsiveImage/ResponsiveImage.tsx @@ -60,7 +60,7 @@ export default function ResponsiveImage( props: { * For fixed-dimension images, pass the same value for the minimum * and maximum values, e.g. `[ 100, 100 ]`. */ - widthRange: Array; + widthRange: [number, number]; } ) { const { alt, diff --git a/tsconfig.json b/tsconfig.json index 2aee2305..9e4a952b 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -13,7 +13,8 @@ "outDir": "dist", "resolveJsonModule": true, "sourceMap": true, - "strictNullChecks": true + "strictNullChecks": true, + "noUncheckedIndexedAccess": true }, "include": [ "src/components/**/*" From fa693ed6828416e5ba3a67cc3c9c1ecf9dda7908 Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Thu, 24 Feb 2022 14:30:31 +0000 Subject: [PATCH 2/2] Add TypeScript types --- dist/Button/Button.d.ts | 8 ++++---- dist/ResponsiveImage/ResponsiveImage.d.ts | 2 +- dist/ResponsiveImage/ResponsiveImage.d.ts.map | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dist/Button/Button.d.ts b/dist/Button/Button.d.ts index 13e3b503..2b0e3497 100644 --- a/dist/Button/Button.d.ts +++ b/dist/Button/Button.d.ts @@ -15,7 +15,7 @@ declare const ButtonLabel: { /** * Visual variations of the button. */ - variant?: "primary" | "secondary" | "warning" | undefined; + variant?: Variant | undefined; }): JSX.Element; defaultProps: { inline: boolean; @@ -70,14 +70,14 @@ declare const Button: (props: { * Function to run when the button is engaged. Forwarded to the button * element. */ - onClick?: ((event: React.UIEvent) => void) | undefined; + onClick?: React.UIEventHandler | undefined; /** * The WAI-ARIA element role. It is always preferable to use the * approporiate HTML element over the role attribute, e.g. * `` is preferred to `