Skip to content

Comments

feat(perf): hoist wrapped signal function#8219

Merged
wmertens merged 2 commits intobuild/v2from
v2-wrapped-signal-fn-hoisting
Jan 4, 2026
Merged

feat(perf): hoist wrapped signal function#8219
wmertens merged 2 commits intobuild/v2from
v2-wrapped-signal-fn-hoisting

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Jan 1, 2026

Hoist wrapped signal function. This is very usefull for loops. In that case we have the same signal function instance, so less memory and possibility to compare instances during diffing

@Varixo Varixo self-assigned this Jan 1, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 1, 2026

⚠️ No Changeset found

Latest commit: 898b779

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo force-pushed the v2-wrapped-signal-fn-hoisting branch from 84aa271 to 7ee9c83 Compare January 1, 2026 19:13
@Varixo Varixo force-pushed the v2-wrapped-signal-fn-hoisting branch from 7ee9c83 to d875827 Compare January 1, 2026 19:21
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 1, 2026

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8219
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8219
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8219
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8219

commit: 898b779

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 898b779

@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development Jan 3, 2026
@Varixo Varixo marked this pull request as ready for review January 3, 2026 08:45
@Varixo Varixo requested a review from a team as a code owner January 3, 2026 08:45
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛞

@wmertens wmertens merged commit 8b282b4 into build/v2 Jan 4, 2026
24 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Jan 4, 2026
@wmertens wmertens deleted the v2-wrapped-signal-fn-hoisting branch January 4, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants