From d49aafd9566245f8fb44428cb5e0551f7fc6bbf3 Mon Sep 17 00:00:00 2001 From: Stephen Shao Date: Tue, 3 Jun 2025 19:27:35 -0400 Subject: [PATCH 1/5] Inits the logic to handle deprecated models --- src/madengine/tools/run_models.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/madengine/tools/run_models.py b/src/madengine/tools/run_models.py index dd528c4e..f9832e4e 100644 --- a/src/madengine/tools/run_models.py +++ b/src/madengine/tools/run_models.py @@ -905,6 +905,13 @@ def run_model(self, model_info: typing.Dict) -> bool: # Environment variable updates for MAD Public CI run_details.gpu_architecture = self.context.ctx["docker_env_vars"]["MAD_SYSTEM_GPU_ARCHITECTURE"] + # Check if model is deprecated + if model_info.get("is_deprecated", False): + print(f"WARNING: Model {model_info['name']} has been deprecated.") + if self.args.skip_deprecated_models: + print(f"Skipping deprecated model {model_info['name']}") + return True # Return success to not affect overall status + # check if model is supported on current gpu architecture, if not skip. list_skip_gpu_arch = [] if ( From 6500483150573d27b3f35f36b7010b90bd42bb74 Mon Sep 17 00:00:00 2001 From: Chetan-AMD Date: Wed, 4 Jun 2025 10:15:49 -0500 Subject: [PATCH 2/5] added --force-deprecated tag + extra warnings for clarity --- src/madengine/mad.py | 4 ++++ src/madengine/tools/run_models.py | 12 +++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/madengine/mad.py b/src/madengine/mad.py index 75bee1ed..f2affd33 100644 --- a/src/madengine/mad.py +++ b/src/madengine/mad.py @@ -125,6 +125,10 @@ def main(): # Run models command parser_run = subparsers.add_parser('run', description="Run LLMs and Deep Learning models on container", help='Run models on container') parser_run.add_argument('--tags', nargs='+', default=[], help="tags to run (can be multiple).") + + # Deprecated Tag + parser_run.add_argument('--force-deprecated', action='store_true', help="Force run deprecated models even if marked deprecated.") + parser_run.add_argument('--timeout', type=int, default=-1, help="time out for model run in seconds; Overrides per-model timeout if specified or default timeout of 7200 (2 hrs).\ Timeout of 0 will never timeout.") parser_run.add_argument('--live-output', action='store_true', help="prints output in real-time directly on STDOUT") diff --git a/src/madengine/tools/run_models.py b/src/madengine/tools/run_models.py index f9832e4e..b4b06c5c 100644 --- a/src/madengine/tools/run_models.py +++ b/src/madengine/tools/run_models.py @@ -906,11 +906,13 @@ def run_model(self, model_info: typing.Dict) -> bool: run_details.gpu_architecture = self.context.ctx["docker_env_vars"]["MAD_SYSTEM_GPU_ARCHITECTURE"] # Check if model is deprecated - if model_info.get("is_deprecated", False): - print(f"WARNING: Model {model_info['name']} has been deprecated.") - if self.args.skip_deprecated_models: - print(f"Skipping deprecated model {model_info['name']}") - return True # Return success to not affect overall status + if model_info.get("is_deprecated", False): + print(f"WARNING: Model {model_info['name']} has been deprecated.") + if self.args.force_deprecated: + print(f"WARNING: Running deprecated model {model_info['name']} due to --force-deprecated flag.") + else: + print(f"WARNING: Skipping execution. No bypass flags mentioned.") + return True # exit early # check if model is supported on current gpu architecture, if not skip. list_skip_gpu_arch = [] From 16c12709adceb54e9f618c99898ae0b1c0230da9 Mon Sep 17 00:00:00 2001 From: Chetan-AMD Date: Wed, 4 Jun 2025 12:20:14 -0500 Subject: [PATCH 3/5] changed --force-deprecated to --ignore-deprecated-flag --- src/madengine/mad.py | 2 +- src/madengine/tools/run_models.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/madengine/mad.py b/src/madengine/mad.py index f2affd33..0b77934e 100644 --- a/src/madengine/mad.py +++ b/src/madengine/mad.py @@ -127,7 +127,7 @@ def main(): parser_run.add_argument('--tags', nargs='+', default=[], help="tags to run (can be multiple).") # Deprecated Tag - parser_run.add_argument('--force-deprecated', action='store_true', help="Force run deprecated models even if marked deprecated.") + parser_run.add_argument('--ignore-deprecated-flag', action='store_true', help="Force run deprecated models even if marked deprecated.") parser_run.add_argument('--timeout', type=int, default=-1, help="time out for model run in seconds; Overrides per-model timeout if specified or default timeout of 7200 (2 hrs).\ Timeout of 0 will never timeout.") diff --git a/src/madengine/tools/run_models.py b/src/madengine/tools/run_models.py index b4b06c5c..f1a2745d 100644 --- a/src/madengine/tools/run_models.py +++ b/src/madengine/tools/run_models.py @@ -908,7 +908,7 @@ def run_model(self, model_info: typing.Dict) -> bool: # Check if model is deprecated if model_info.get("is_deprecated", False): print(f"WARNING: Model {model_info['name']} has been deprecated.") - if self.args.force_deprecated: + if self.args.ignore-deprecated-flag: print(f"WARNING: Running deprecated model {model_info['name']} due to --force-deprecated flag.") else: print(f"WARNING: Skipping execution. No bypass flags mentioned.") From f6c1930ecda9b03451e63b43c6f8cc8a61b890e5 Mon Sep 17 00:00:00 2001 From: Chetan-AMD Date: Thu, 5 Jun 2025 09:32:32 -0500 Subject: [PATCH 4/5] changed tag to have _ not - --- src/madengine/mad.py | 2 +- src/madengine/tools/run_models.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/madengine/mad.py b/src/madengine/mad.py index 0b77934e..dec8e531 100644 --- a/src/madengine/mad.py +++ b/src/madengine/mad.py @@ -127,7 +127,7 @@ def main(): parser_run.add_argument('--tags', nargs='+', default=[], help="tags to run (can be multiple).") # Deprecated Tag - parser_run.add_argument('--ignore-deprecated-flag', action='store_true', help="Force run deprecated models even if marked deprecated.") + parser_run.add_argument('--ignore_deprecated_flag', action='store_true', help="Force run deprecated models even if marked deprecated.") parser_run.add_argument('--timeout', type=int, default=-1, help="time out for model run in seconds; Overrides per-model timeout if specified or default timeout of 7200 (2 hrs).\ Timeout of 0 will never timeout.") diff --git a/src/madengine/tools/run_models.py b/src/madengine/tools/run_models.py index f1a2745d..bdeaacb8 100644 --- a/src/madengine/tools/run_models.py +++ b/src/madengine/tools/run_models.py @@ -908,7 +908,7 @@ def run_model(self, model_info: typing.Dict) -> bool: # Check if model is deprecated if model_info.get("is_deprecated", False): print(f"WARNING: Model {model_info['name']} has been deprecated.") - if self.args.ignore-deprecated-flag: + if self.args.ignore_deprecated_flag: print(f"WARNING: Running deprecated model {model_info['name']} due to --force-deprecated flag.") else: print(f"WARNING: Skipping execution. No bypass flags mentioned.") From 820a1ddaa21f5369bd94fa1d3f6fd69e630b930a Mon Sep 17 00:00:00 2001 From: Chetan-AMD Date: Fri, 6 Jun 2025 10:52:24 -0500 Subject: [PATCH 5/5] changed hyphens to underscores, and updated warning tag --- src/madengine/mad.py | 2 +- src/madengine/tools/run_models.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/madengine/mad.py b/src/madengine/mad.py index dec8e531..0b77934e 100644 --- a/src/madengine/mad.py +++ b/src/madengine/mad.py @@ -127,7 +127,7 @@ def main(): parser_run.add_argument('--tags', nargs='+', default=[], help="tags to run (can be multiple).") # Deprecated Tag - parser_run.add_argument('--ignore_deprecated_flag', action='store_true', help="Force run deprecated models even if marked deprecated.") + parser_run.add_argument('--ignore-deprecated-flag', action='store_true', help="Force run deprecated models even if marked deprecated.") parser_run.add_argument('--timeout', type=int, default=-1, help="time out for model run in seconds; Overrides per-model timeout if specified or default timeout of 7200 (2 hrs).\ Timeout of 0 will never timeout.") diff --git a/src/madengine/tools/run_models.py b/src/madengine/tools/run_models.py index bdeaacb8..4e3df620 100644 --- a/src/madengine/tools/run_models.py +++ b/src/madengine/tools/run_models.py @@ -909,7 +909,7 @@ def run_model(self, model_info: typing.Dict) -> bool: if model_info.get("is_deprecated", False): print(f"WARNING: Model {model_info['name']} has been deprecated.") if self.args.ignore_deprecated_flag: - print(f"WARNING: Running deprecated model {model_info['name']} due to --force-deprecated flag.") + print(f"WARNING: Running deprecated model {model_info['name']} due to --ignore-deprecated-flag.") else: print(f"WARNING: Skipping execution. No bypass flags mentioned.") return True # exit early