From 626f585acf9469fc51f8050c1a41db239b4017f9 Mon Sep 17 00:00:00 2001 From: Pasha Stetsenko Date: Fri, 8 Sep 2017 10:31:02 -0700 Subject: [PATCH 1/2] Added a test case for reading large integer --- inst/tests/tests.Rraw | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/inst/tests/tests.Rraw b/inst/tests/tests.Rraw index b4e5680db1..99dec1ee9b 100644 --- a/inst/tests/tests.Rraw +++ b/inst/tests/tests.Rraw @@ -10508,6 +10508,10 @@ test(1823.2, DT$z, seq(11, 2)) DT[, z := ncol(.SD) + get("y"), .SDcols = c("x", "z")] test(1823.3, DT$z, seq(12, 3)) +# Issue 2250 +test(1824, fread("A,B\n1,384325987234905827340958734572934\n"), data.table(A=1L, B="384325987234905827340958734572934")) + + ########################## # TODO: Tests involving GForce functions needs to be run with optimisation level 1 and 2, so that both functions are tested all the time. From f4b2c4333b411dfc2d395428cdac2b09287b49c7 Mon Sep 17 00:00:00 2001 From: Pasha Stetsenko Date: Fri, 8 Sep 2017 10:36:36 -0700 Subject: [PATCH 2/2] Add a note in NEWS.md --- NEWS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS.md b/NEWS.md index f4ee8b7866..c64252ca46 100644 --- a/NEWS.md +++ b/NEWS.md @@ -81,6 +81,9 @@ 17. `.SD` would incorrectly include symbol on lhs of `:=` when `.SDcols` is specified and `get()` appears in `j`. Thanks @renkun-ken for reporting and the PR. Closes #2326. +18. Integer values that are too large to fit in `int64` will now be read as strings [#2250](https://github.com/Rdatatable/data.table/issues/2250). + + #### NOTES 1. `?data.table` makes explicit the option of using a `logical` vector in `j` to select columns, [#1978](https://github.com/Rdatatable/data.table/issues/1978). Thanks @Henrik-P for the note and @MichaelChirico for filing.