From 1f6ae067f558e9e73c2194ad7ed588ae19f230e7 Mon Sep 17 00:00:00 2001 From: jangorecki Date: Sat, 2 Jun 2018 09:54:22 +0530 Subject: [PATCH 1/2] export split.data.table, closes #2920 --- NAMESPACE | 3 ++- NEWS.md | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/NAMESPACE b/NAMESPACE index cdc2d7ddae..78f9db4166 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -76,7 +76,6 @@ S3method(as.matrix, data.table) #S3method(cbind, data.table) #S3method(rbind, data.table) export(.rbind.data.table) -S3method(split, data.table) S3method(dim, data.table) S3method(dimnames, data.table) S3method("dimnames<-", data.table) @@ -93,6 +92,8 @@ S3method(Ops, data.table) S3method(anyDuplicated, data.table) +export(split.data.table) +S3method(split, data.table) export(melt) export(melt.data.table) S3method(melt, data.table) diff --git a/NEWS.md b/NEWS.md index ad95f1cb01..ca0e68c517 100644 --- a/NEWS.md +++ b/NEWS.md @@ -9,6 +9,8 @@ #### NOTES +1. `split.data.table` function has been exported so can be directly accessed without need to use method dispatch mechanism. Closes [#2920](https://github.com/Rdatatable/data.table/issues/2920). + ### Changes in v1.11.4 (on CRAN 27 May 2018) From 4739720940ea9b5e866d51d442d22076f062e0f2 Mon Sep 17 00:00:00 2001 From: Matt Dowle Date: Thu, 16 Aug 2018 19:26:16 -0700 Subject: [PATCH 2/2] Added 'properly' to convey it was supposed to be. --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 7f6259e30f..2d1777de6b 100644 --- a/NEWS.md +++ b/NEWS.md @@ -58,7 +58,7 @@ Warning message: truncated to 3. ``` -2. `split.data.table` method is now exported, [#2920](https://github.com/Rdatatable/data.table/issues/2920). But we don't recommend it because `split` copies all the pieces into new memory. +2. `split.data.table` method is now properly exported, [#2920](https://github.com/Rdatatable/data.table/issues/2920). But we don't recommend it because `split` copies all the pieces into new memory. ### Changes in v1.11.4 (on CRAN 27 May 2018)