diff --git a/NEWS.md b/NEWS.md index 63a1a259bf..3e46498067 100644 --- a/NEWS.md +++ b/NEWS.md @@ -129,7 +129,6 @@ # TRUE ``` - #### BUG FIXES 1. `first`, `last`, `head` and `tail` by group no longer error in some cases, [#2030](https://github.com/Rdatatable/data.table/issues/2030) [#3462](https://github.com/Rdatatable/data.table/issues/3462). Thanks to @franknarf1 for reporting. @@ -189,6 +188,8 @@ # 2: 2 a ``` +23. Incorrect sorting/grouping results due to a bug in Intel's `icc` compiler 2019 (Version 19.0.4.243 Build 20190416) has been worked around thanks to a report and fix by Sebastian Freundt, [#3647](https://github.com/Rdatatable/data.table/issues/3647). Please run `data.table::test.data.table()`. If that passes, your installation does not have the problem. + #### NOTES 1. `rbindlist`'s `use.names="check"` now emits its message for automatic column names (`"V[0-9]+"`) too, [#3484](https://github.com/Rdatatable/data.table/pull/3484). See news item 5 of v1.12.2 below. diff --git a/src/forder.c b/src/forder.c index c507aacc2a..6135260986 100644 --- a/src/forder.c +++ b/src/forder.c @@ -900,10 +900,12 @@ void radix_r(const int from, const int to, const int radix) { TEND(10) if (sortType!=0) { // Always ascending sort here (even when sortType==-1) because descending was prepared in write_key - my_counts[my_key[0]] = 1; - int i=1; - while (skip && i=my_key[i-1]); i++; } - while (i= comparison + for (int i=0; i