Commit 34b8c93
fix(#29): resolve duplicate function and API mismatch from merge
Critical fixes discovered by Codex review:
1. [P0] Remove duplicate GetCampaignHistory function (lines 177-193)
- Merge left two function definitions (178 and 217)
- Kept the correct version with days parameter support
2. [P0] Remove sparkline from CampaignRowView
- Line 18 called SparklineView(pid:) which no longer exists
- Investor-friendly UI (develop) already has sparkline in CampaignDetailView
- Loading history for every row would cause N+1 query performance issues
Refs: backend/internal/handler/campaigns.go:178, ios/KickWatch/Sources/Views/CampaignRowView.swift:18
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 722a8fc commit 34b8c93
2 files changed
Lines changed: 7 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | | - | |
| 81 | + | |
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | 177 | | |
196 | 178 | | |
197 | 179 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 17 | + | |
| 18 | + | |
22 | 19 | | |
23 | 20 | | |
24 | 21 | | |
| |||
0 commit comments