From 6c514f43b93a81862f4d03bcaf130032961c2223 Mon Sep 17 00:00:00 2001
From: Robert <robert.j.holstein@gmail.com>
Date: Mon, 7 Oct 2024 19:50:03 -0400
Subject: [PATCH] Add set network and set camera name functions

---
 examples/basic_usage.py      |  1 +
 examples/network_config.py   | 59 ++++++++++++++++++++++++++++++++++++
 reolinkapi/mixins/device.py  | 19 ++++++++++++
 reolinkapi/mixins/network.py | 36 ++++++++++++++++++++++
 4 files changed, 115 insertions(+)
 create mode 100644 examples/network_config.py

diff --git a/examples/basic_usage.py b/examples/basic_usage.py
index 0ba744c..1fa5bdd 100644
--- a/examples/basic_usage.py
+++ b/examples/basic_usage.py
@@ -9,3 +9,4 @@
     dst = cam.get_dst()
     ok = cam.add_user("foo", "bar", "admin")
     alarm = cam.get_alarm_motion()
+    cam.set_device_name(name='my_camera')
\ No newline at end of file
diff --git a/examples/network_config.py b/examples/network_config.py
new file mode 100644
index 0000000..fa5eaf4
--- /dev/null
+++ b/examples/network_config.py
@@ -0,0 +1,59 @@
+import os
+from configparser import RawConfigParser
+from reolinkapi import Camera
+
+
+def read_config(props_path: str) -> dict:
+    """Reads in a properties file into variables.
+
+    NB! this config file is kept out of commits with .gitignore. The structure of this file is such:
+    # secrets.cfg
+        [camera]
+        ip={ip_address}
+        username={username}
+        password={password}
+    """
+    config = RawConfigParser()
+    assert os.path.exists(props_path), f"Path does not exist: {props_path}"
+    config.read(props_path)
+    return config
+
+
+# Read in your ip, username, & password
+#   (NB! you'll likely have to create this file. See tests/test_camera.py for details on structure)
+config = read_config('camera.cfg')
+
+ip = config.get('camera', 'ip')
+un = config.get('camera', 'username')
+pw = config.get('camera', 'password')
+
+# Connect to camera
+cam = Camera(ip, un, pw)
+
+# Get current network settings
+current_settings = cam.get_network_general()
+print("Current settings:", current_settings)
+
+# Configure DHCP
+cam.set_network_settings(
+    ip="",
+    gateway="",
+    mask="",
+    dns1="",
+    dns2="",
+    mac=current_settings[0]['value']['LocalLink']['mac'],
+    use_dhcp=True,
+    auto_dns=True
+)
+
+# Configure static IP
+# cam.set_network_settings(
+#     ip="192.168.1.102",
+#     gateway="192.168.1.1",
+#     mask="255.255.255.0",
+#     dns1="8.8.8.8",
+#     dns2="8.8.4.4",
+#     mac=current_settings[0]['value']['LocalLink']['mac'],
+#     use_dhcp=False,
+#     auto_dns=False
+# )
\ No newline at end of file
diff --git a/reolinkapi/mixins/device.py b/reolinkapi/mixins/device.py
index 684be45..21b7961 100644
--- a/reolinkapi/mixins/device.py
+++ b/reolinkapi/mixins/device.py
@@ -5,6 +5,25 @@ class DeviceAPIMixin:
     """API calls for getting device information."""
     DEFAULT_HDD_ID = [0]
 
+    def set_device_name(self, name: str) -> bool:
+        """
+        Set the device name of the camera.
+        :param name: The new name for the device
+        :return: bool indicating success
+        """
+        body = [{"cmd": "SetDevName", "action": 0, "param": {"DevName": {"name": name}}}]
+        self._execute_command('SetDevName', body)
+        print(f"Successfully set device name to: {name}")
+        return True
+
+    def get_device_name(self) -> Dict:
+        """
+        Get the device name of the camera.
+        :return: Dict containing the device name
+        """
+        body = [{"cmd": "GetDevName", "action": 0, "param": {}}]
+        return self._execute_command('GetDevName', body)
+    
     def get_hdd_info(self) -> Dict:
         """
         Gets all HDD and SD card information from Camera
diff --git a/reolinkapi/mixins/network.py b/reolinkapi/mixins/network.py
index f4fe4a6..fc4bd7a 100644
--- a/reolinkapi/mixins/network.py
+++ b/reolinkapi/mixins/network.py
@@ -3,6 +3,42 @@
 
 class NetworkAPIMixin:
     """API calls for network settings."""
+    def set_network_settings(self, ip: str, gateway: str, mask: str, dns1: str, dns2: str, mac: str,
+                            use_dhcp: bool = True, auto_dns: bool = True) -> Dict:
+        """
+        Set network settings including IP, gateway, subnet mask, DNS, and connection type (DHCP or Static).
+        
+        :param ip: str
+        :param gateway: str
+        :param mask: str
+        :param dns1: str
+        :param dns2: str
+        :param mac: str
+        :param use_dhcp: bool
+        :param auto_dns: bool
+        :return: Dict
+        """
+        body = [{"cmd": "SetLocalLink", "action": 0, "param": {
+            "LocalLink": {
+                "dns": {
+                    "auto": 1 if auto_dns else 0,
+                    "dns1": dns1,
+                    "dns2": dns2
+                },
+                "mac": mac,
+                "static": {
+                    "gateway": gateway,
+                    "ip": ip,
+                    "mask": mask
+                },
+                "type": "DHCP" if use_dhcp else "Static"
+            }
+        }}]
+        
+        return self._execute_command('SetLocalLink', body)
+        print("Successfully Set Network Settings")
+        return True
+
     def set_net_port(self, http_port: float = 80, https_port: float = 443, media_port: float = 9000,
                      onvif_port: float = 8000, rtmp_port: float = 1935, rtsp_port: float = 554) -> bool:
         """