From 2f765bcc30e1fdc7352fbb348a08b21b98081ebe Mon Sep 17 00:00:00 2001 From: Robert Date: Tue, 8 Oct 2024 19:51:13 -0400 Subject: [PATCH 1/2] Add set NTP --- examples/network_config.py | 3 +++ reolinkapi/mixins/network.py | 21 +++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/examples/network_config.py b/examples/network_config.py index fa5eaf4..51b1956 100644 --- a/examples/network_config.py +++ b/examples/network_config.py @@ -30,6 +30,9 @@ def read_config(props_path: str) -> dict: # Connect to camera cam = Camera(ip, un, pw) +# Set NTP +cam.set_ntp(enable=True, interval=1440, port=123, server="time-b.nist.gov") + # Get current network settings current_settings = cam.get_network_general() print("Current settings:", current_settings) diff --git a/reolinkapi/mixins/network.py b/reolinkapi/mixins/network.py index fc4bd7a..884a24b 100644 --- a/reolinkapi/mixins/network.py +++ b/reolinkapi/mixins/network.py @@ -72,6 +72,27 @@ def set_wifi(self, ssid: str, password: str) -> Dict: }}}] return self._execute_command('SetWifi', body) + def set_ntp(self, enable: bool = True, interval: int = 1440, port: int = 123, server: str = "pool.ntp.org") -> Dict: + """ + Set NTP settings. + + :param enable: bool + :param interval: int + :param port: int + :param server: str + :return: Dict + """ + body = [{"cmd": "SetNtp", "action": 0, "param": { + "Ntp": { + "enable": 1 if enable else 0, + "interval": interval, + "port": port, + "server": server + }}}] + response = self._execute_command('SetNtp', body) + print("Successfully Set NTP Settings") + return response + def get_net_ports(self) -> Dict: """ Get network ports From e5e7017f234bd705e62b6167234f38a2ae635783 Mon Sep 17 00:00:00 2001 From: Alano Terblanche <18033717+Benehiko@users.noreply.github.com> Date: Mon, 9 Dec 2024 11:46:05 +0100 Subject: [PATCH 2/2] chore: convert bool to int --- reolinkapi/mixins/network.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reolinkapi/mixins/network.py b/reolinkapi/mixins/network.py index 884a24b..ae44ba4 100644 --- a/reolinkapi/mixins/network.py +++ b/reolinkapi/mixins/network.py @@ -84,7 +84,7 @@ def set_ntp(self, enable: bool = True, interval: int = 1440, port: int = 123, se """ body = [{"cmd": "SetNtp", "action": 0, "param": { "Ntp": { - "enable": 1 if enable else 0, + "enable": int(enable), "interval": interval, "port": port, "server": server