This repository was archived by the owner on Nov 5, 2025. It is now read-only.
[NEW] Message attachment action and message reaction definitions#48
Merged
[NEW] Message attachment action and message reaction definitions#48
Conversation
Contributor
Author
|
@timkinnane addressed comments from: RocketChat/Rocket.Chat.Apps-ts-definition@5e9478e#commitcomment-30338091 |
graywolf336
previously requested changes
Aug 30, 2018
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
Can you add the new interfaces to the index.ts file inside the messages folder?
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 59.58% 61.46% +1.87%
==========================================
Files 55 62 +7
Lines 1997 2094 +97
Branches 312 312
==========================================
+ Hits 1190 1287 +97
Misses 807 807
Continue to review full report at Codecov.
|
Member
|
PR on main project already merged =) |
graywolf336
changed the title
rodrigok
approved these changes
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved from: RocketChat/Rocket.Chat.Apps-ts-definition#54