This repository was archived by the owner on Nov 5, 2025. It is now read-only.
[NEW] Add handlers for message updates#64
Merged
rodrigok merged 4 commits intoRocketChat:masterfrom Sep 25, 2018
Merged
Conversation
cardoso
force-pushed
the
feat/message_update_handlers.63
branch
from
3802f26 to
11b1ce5
Compare
geekgonecrazy
approved these changes
Sep 20, 2018
Contributor
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
Code style wise this matches great. Function wise this seems to work exactly as intended 👍
Member
Author
|
Thanks for the review @geekgonecrazy 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just followed the steps of the
message senthandlers and implemented the ones formessage updates.This app in the
edit-testsbranch can be used to test the additions: https://github.com/cardoso/Rocket.Chat.ContentFilter/tree/edit-testsCloses #63
PR needs to be merged in main repo: RocketChat/Rocket.Chat#11993