Skip to content

Comments

Chore: Migrate redux module connect to typescript#3603

Merged
dnlsilva merged 5 commits intodevelopfrom
chore/migration-ts-redux-connect-v2
Jan 26, 2022
Merged

Chore: Migrate redux module connect to typescript#3603
dnlsilva merged 5 commits intodevelopfrom
chore/migration-ts-redux-connect-v2

Conversation

@dnlsilva
Copy link
Contributor

Proposed changes

Migrate redux module connect to typescript

Issue(s)

How to test or reproduce

Trying to connect to a different server than the current one

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dnlsilva dnlsilva merged commit 19a0c1d into develop Jan 26, 2022
@dnlsilva dnlsilva deleted the chore/migration-ts-redux-connect-v2 branch January 26, 2022 20:05
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…-redux-connect-v2

Chore: Migrate redux module connect to typescript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants