Skip to content

Comments

Chore: Migrate i18n to Typescript #3988

Merged
reinaldonetof merged 20 commits intodevelopfrom
chore.ts-i18n
Apr 14, 2022
Merged

Chore: Migrate i18n to Typescript #3988
reinaldonetof merged 20 commits intodevelopfrom
chore.ts-i18n

Conversation

@reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Mar 29, 2022 •
edited
Loading

Proposed changes

Issue(s)

How to test or reproduce

  • Check if the translations are work properly
  • Go to Settings -> Language -> change between the languages

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@reinaldonetof reinaldonetof self-assigned this Mar 29, 2022
@reinaldonetof reinaldonetof changed the title Chore: Migrate i18n to Typescript and fix the Left and Right actions in RoomItem Chore: Migrate i18n to Typescript Mar 29, 2022
diegolmello
diegolmello previously requested changes Mar 31, 2022
View reviewed changes
@dnlsilva
Copy link
Contributor

dnlsilva commented Mar 31, 2022

Adding one more comment to what @diegolmello said.
If the migration is about i18n, I don't think it's ideal to change things that are unrelated to i18n, even if they look wrong. Better would be to create a task to change this in the future.

PR consistency is very important for tracking.

dnlsilva
dnlsilva suggested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@dnlsilva dnlsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The i18 part is ok, but as we said, it will remove the part that changes other things and open another PR with these changes.

@reinaldonetof
Copy link
Contributor Author

reinaldonetof commented Apr 11, 2022

The i18 part is ok, but as we said, it will remove the part that changes other things and open another PR with these changes.

Hey, @GleidsonDaniel I created a new function called isTranslated to be a function to test if the string to translate exists. Also, I could merge the develop here and deleted the files from

@reinaldonetof reinaldonetof merged commit 25c37c1 into develop Apr 14, 2022
@reinaldonetof reinaldonetof deleted the chore.ts-i18n branch April 14, 2022 20:30
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
@reinaldonetof @diegolmello
Chore: Migrate i18n to Typescript (RocketChat#3988)
c763386 
* Chore: Migrate i18n to Typescript and fix the Left and Right actions in RoomItem

* remove fix to roomItem

* update storyshot

* Chore: Migrate i18n to Typescript and fix the Left and Right actions in RoomItem

* remove fix to roomItem

* update storyshot

* fix removed itens

* fix changes requested

* interface for i18n, added resolveJsonModule to tsconfig.json

* tweak at error alert

* fix storyshot

* refactor comments

* create function isTranslated

* fix accessibilityLabel

Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello left review comments

+1 more reviewer

@dnlsilva dnlsilva dnlsilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@reinaldonetof reinaldonetof

Labels

🚚 chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reinaldonetof @dnlsilva @diegolmello