[FIX] Create a discussion from NewMessageView#4003
Merged
reinaldonetof merged 4 commits intodevelopfrom Apr 8, 2022
Merged
Conversation
AlexAlexandre
suggested changes
Apr 4, 2022
AlexAlexandre
approved these changes
Apr 4, 2022
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
* [FIX] Create a discussion from NewMessageView * fix the itemData.value to any * minor tweak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Discussions are broken after merged by PR #3939
Exactly at this point: https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/3939/files#diff-1d629f66de52d1d125580803422f6f3d9df9b9b2bd89133846b7c3ff18b85750R57
To resolve this, we needed to change the way we were doing the keyExtractor
Issue(s)
How to test or reproduce
Create a Discussion from NewMessageView
NewMessageViewthen try to create a DiscussionEncryptedif you entered your E2E keyCreate a Discussion inside any channel
+iconCreate DiscussionScreenshots
Types of changes
Checklist
Further comments