Skip to content

[FIX] Create a discussion from NewMessageView#4003

Merged
reinaldonetof merged 4 commits intodevelopfrom
fix.create-discussion-multiselect
Apr 8, 2022
Merged

[FIX] Create a discussion from NewMessageView#4003
reinaldonetof merged 4 commits intodevelopfrom
fix.create-discussion-multiselect

Conversation

@reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Mar 31, 2022

Proposed changes

Discussions are broken after merged by PR #3939

Exactly at this point: https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/3939/files#diff-1d629f66de52d1d125580803422f6f3d9df9b9b2bd89133846b7c3ff18b85750R57

To resolve this, we needed to change the way we were doing the keyExtractor

Issue(s)

How to test or reproduce

Create a Discussion from NewMessageView

  • Go to NewMessageView then try to create a Discussion
  • Should work properly and shows the button Encrypted if you entered your E2E key

Create a Discussion inside any channel

  • Open a channel
  • Click on + icon
  • Then will show actions and click in Create Discussion

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@AlexAlexandre AlexAlexandre self-requested a review April 4, 2022 21:43
@reinaldonetof reinaldonetof merged commit 8268bee into develop Apr 8, 2022
@reinaldonetof reinaldonetof deleted the fix.create-discussion-multiselect branch April 8, 2022 22:53
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
* [FIX] Create a discussion from NewMessageView

* fix the itemData.value to any

* minor tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments