[IMPROVE] Allow custom rocketchat username for crowd users and enable login via email/crowd_username#12981
Merged
rodrigok merged 10 commits intoRocketChat:developfrom Feb 22, 2019
steerben:fix/allow-custom-rocketchat-usernames-for-crowd-users
Merged
[IMPROVE] Allow custom rocketchat username for crowd users and enable login via email/crowd_username#12981rodrigok merged 10 commits intoRocketChat:developfrom steerben:fix/allow-custom-rocketchat-usernames-for-crowd-users
rodrigok merged 10 commits intoRocketChat:developfrom
steerben:fix/allow-custom-rocketchat-usernames-for-crowd-users
Conversation
- Enable custom rocketchat usernames for crowd users - Enable login via rocketchat username, crowd_username and email address - Don't authenticate local users against crowd - Allow/Disallow resyncing/overwride of local usernames with crowd usernames in crowd options - Consistent user sync on login and on cron sync
|
|
rodrigok
previously requested changes
Jan 19, 2019
Integrate PR suggestions/improvements
Contributor
Author
|
Any chance already to have a look at it again @rodrigok ? |
Member
|
Refs: #11483 |
Hudell
suggested changes
Feb 18, 2019
Contributor
Hudell
left a comment
Hudell
left a comment
There was a problem hiding this comment.
I had to make those changes to make it work.
Contributor
Author
|
Hey @Hudell thanks for the suggestions, I changed the code accordingly. |
Contributor
Author
|
Merged develop into branch and fixed direct settings access, since RocketChat object is not globally available anymore. |
Hudell
approved these changes
Feb 20, 2019
rodrigok
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to close issue #12979