Skip to content

[FIX] Fixed rocketchat-oembed meta fragment pulling#13056

Merged
rodrigok merged 8 commits intoRocketChat:developfrom
mieweb:develop
Mar 2, 2019
Merged

[FIX] Fixed rocketchat-oembed meta fragment pulling#13056
rodrigok merged 8 commits intoRocketChat:developfrom
mieweb:develop

Conversation

@wreiske
Copy link
Contributor

@wreiske wreiske commented Dec 30, 2018

Closes #13055
image

Before

127.0.0.1 - - [30/Dec/2018:20:50:58 +0000] "GET /math HTTP/1.1" 200 26333 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2227.0 Safari/537.36"

After

127.0.0.1 - - [30/Dec/2018:20:50:58 +0000] "GET /math?_escaped_fragment_= HTTP/1.1" 200 26333 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2227.0 Safari/537.36"

@wreiske
Copy link
Contributor Author

wreiske commented Dec 30, 2018

Just as a note: this also respects any existing query strings.

127.0.0.1 - - [30/Dec/2018:20:49:32 +0000] "GET /math?test=true&_escaped_fragment_= HTTP/1.1" 200 26383 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2227.0 Safari/537.36"

@sampaiodiego sampaiodiego added this to the 0.75.0 milestone Jan 21, 2019
@rodrigok rodrigok merged commit 54b8dbd into RocketChat:develop Mar 2, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments