Merged
Conversation
…#13369) Closes #11604 Closes #12399 An `else` directive introduced the issue at version 0.67.0: https://github.com/RocketChat/Rocket.Chat/pull/10749/files#diff-ff8f9f02a53856a978c533000a92bd12R70
* [IMPROVE] Reduce memory consume of HipChat Enterprise importer * [IMPROVE] Add users of public channels on HipChat Enterprise importer * Hipchat importer: add support to import folders * Fix condition * [FIX] Deleted users imported as active * Added more info to log * Prevent issues with complex user ids * Improve importer logs * Improve code quality * Fixed import of attached files on channels * Fixed room names imported from hipchat enterprise * Fixed attachment import
* Add option "permissionsRequired" to API * Fix apps permissions * Revert change on unauthorized error response
* Fix misspelled language setting name * Fix emails translations not using server's language
* Properly escape custom emoji names for pattern matching * Cache regexp to render ~3.4 times faster
* Fixes #12892 * Removed trailing and leading spaces in variable names * Aadded double underscores where only single underscores were used * Updated some variable names which were translated as well * Fix __length__
* [IMPROVE] Open rooms quicker * Close observer on room destroy * Fix tests * Back to cursor and improve permission query * More improvements
ggazzo
approved these changes
Feb 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2019-02-13 · 3 🚀 · 11 🐛 · 2 🔍 · 9 👩💻👨💻Engine versions
8.11.46.4.13.2, 3.4, 3.6, 4.0🚀 Improvements
🐛 Bug fixes
🔍 Minor changes
👩💻👨💻 Contributors 😍
👩💻👨💻 Core Team 🤓