[FIX] Translation interpolations for many languages#13751
Merged
sampaiodiego merged 26 commits intoRocketChat:developfrom Mar 19, 2019
Merged
[FIX] Translation interpolations for many languages#13751sampaiodiego merged 26 commits intoRocketChat:developfrom
sampaiodiego merged 26 commits intoRocketChat:developfrom
Conversation
Member
|
@sampaiodiego do we need to upload the files directly to LingoHub once this is merged? Or are we still doing the auto-fetch from here? |
Member
|
@engelgabriel it is currently turned off for languages other than english.. I'll turned it on again as we're already missing some translations there. |
sampaiodiego
requested changes
Mar 18, 2019
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
there is no need to do any changes on cleanHistory.js file.. the usage of the t function is correct and working there.
all other changes on translation files are welcome.
sampaiodiego
requested changes
Mar 18, 2019
fliptrail
force-pushed
the
explamation-fix
branch
from
97c43d7 to
db6f83d
Compare
Contributor
Author
|
@sampaiodiego Please review now. |
sampaiodiego
requested changes
Mar 18, 2019
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
there are many others where Prune_Warning_all became %srning_all
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Contributor
Author
|
Looks like there was a problem with my RegEx. Will see to it tomorrow. |
sampaiodiego
changed the title
sampaiodiego
approved these changes
Mar 19, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12130, Closes #12001
Fixes these and some string modifier issues.
Initial State
Final State