Skip to content

Comments

[FIX] No feedback when adding users that already exists in a room#14534

Merged
rodrigok merged 8 commits intodevelopfrom
notify-users-already-exists
May 17, 2019
Merged

[FIX] No feedback when adding users that already exists in a room#14534
rodrigok merged 8 commits intodevelopfrom
notify-users-already-exists

Conversation

@MarcosSpessatto
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto commented May 17, 2019

A solution to issue #13879. With this we can issue an elegant little notification, which is only visible to the user if a the user invites an already existing member to a room.

Rocket Chat notification

Open this pull request based on #14142 since the original branch was deleted. Thanks @gsunit.

Closes #13879
Closes #14142

@MarcosSpessatto MarcosSpessatto added this to the 1.1.0 milestone May 17, 2019
@MarcosSpessatto MarcosSpessatto requested a review from rodrigok May 17, 2019 01:12
@rodrigok rodrigok changed the title [FIX] Notify users already exists [FIX] No feedback when adding users that already exists in a room May 17, 2019
@rodrigok rodrigok merged commit 80bbc64 into develop May 17, 2019
@rodrigok rodrigok deleted the notify-users-already-exists branch May 17, 2019 18:37
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When an already existing user is added in group is doesn't shows that user already exists.

3 participants