[IMPROVE] Added timer in video message recorder#16221
Merged
ggazzo merged 2 commits intoRocketChat:developfrom Feb 20, 2020
ashwaniYDV:timer
Merged
[IMPROVE] Added timer in video message recorder#16221ggazzo merged 2 commits intoRocketChat:developfrom ashwaniYDV:timer
ggazzo merged 2 commits intoRocketChat:developfrom
ashwaniYDV:timer
Conversation
Contributor
Author
|
@tassoevan @ggazzo Would you please review |
Contributor
|
I like this! IMO it may be nice to not show the timer until the record button is pressed, but that's just my opinion. +1 |
Contributor
Author
@wreiske I too agree with you. |
Contributor
Author
|
@wreiske I have done the changes so that "00:00" is not displayed initially :) |
Contributor
Author
|
@sampaiodiego Kindly please review :) |
sampaiodiego
requested review from
a team
and removed request for
sampaiodiego
ggazzo
approved these changes
Feb 3, 2020
ggazzo
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16220
It has been moved to feature request
RocketChat/feature-requests#262
After changes:
Before changes: