[FIX] Show error message if password and confirm password not equal #16247
Merged
ggazzo merged 4 commits intoRocketChat:developfrom Mar 19, 2020
ashwaniYDV:pwdconfpwdmismatch
Merged
[FIX] Show error message if password and confirm password not equal #16247ggazzo merged 4 commits intoRocketChat:developfrom ashwaniYDV:pwdconfpwdmismatch
ggazzo merged 4 commits intoRocketChat:developfrom
ashwaniYDV:pwdconfpwdmismatch
Conversation
gabriellsh
previously approved these changes
Jan 27, 2020
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for your help.
sampaiodiego
requested changes
Mar 12, 2020
| <div class="rc-input__error-icon"> | ||
| {{> icon block="rc-input__error-icon" icon="warning" classes="rc-input__error-icon-svg"}} | ||
| </div> | ||
| <div class="rc-input__error-message">{{_ 'Password_Confirmpassword_Mismatch'}}</div> |
Member
There was a problem hiding this comment.
Suggested change
| <div class="rc-input__error-message">{{_ 'Password_Confirmpassword_Mismatch'}}</div> | |
| <div class="rc-input__error-message">{{_ "Passwords_do_not_match"}}</div> |
| "Password_Changed_Email_Subject": "[Site_Name] - Password Changed", | ||
| "Password_changed_section": "Password Changed", | ||
| "Password_changed_successfully": "Password changed successfully", | ||
| "Password_Confirmpassword_Mismatch": "Passwords do not match", |
Member
There was a problem hiding this comment.
Suggested change
| "Password_Confirmpassword_Mismatch": "Passwords do not match", | |
| "Passwords_do_not_match": "Passwords do not match", |
…nto pwdconfpwdmismatch
|
|
Contributor
Author
|
hi @sampaiodiego I have done the requested changes |
ggazzo
approved these changes
Mar 19, 2020
ggazzo
changed the title
ggazzo
added a commit
to wreiske/Rocket.Chat
that referenced
this pull request
Mar 19, 2020
…4892-wreiske-user-status-bubbles * 'develop' of github.com:RocketChat/Rocket.Chat: (540 commits) [FIX] Show error message if password and confirm password not equal (RocketChat#16247) [FIX] Message quote button inside threads (RocketChat#16925) Fix wrong imported library meteor/tap:i18n lint [IMPROVE] User gets feedback when a message has been starred or unstarred (RocketChat#13860) [FIX] admin can sort users by email in directory view (RocketChat#15796) [FIX] Pinned messages wouldn't collapse (RocketChat#16188) [IMPROVE] Added border to page header. (RocketChat#16792) [FIX] Correct thread messages display in context bar. (RocketChat#16835) [FIX] Public channel cannot be acessed via URL when 'Allow Anonymous Read' is active (RocketChat#16914) Fixed Line break incorrectly being called apostrophe (RocketChat#16918) [IMPROVE] Context menu autofocus (RocketChat#16915) Improve room types usage (RocketChat#16753) [NEW] API `users.deactivateIdle` for mass-disabling of idle users (RocketChat#16849) [NEW] API to logout from other locations (RocketChat#16193) [IMPROVE] Add option to require authentication on user's shield endpoint (RocketChat#16845) [FIX] Custom OAuth Bug (RocketChat#16811) [FIX] Integrations page pagination (RocketChat#16838) reset package-lock to upstream Apply suggestions from code review ...
ggazzo
added a commit
that referenced
this pull request
Mar 20, 2020
…ultiple-users* 'develop' of github.com:RocketChat/Rocket.Chat: (53 commits) [FIX] Show error message if password and confirm password not equal (#16247) [FIX] Message quote button inside threads (#16925) Fix wrong imported library meteor/tap:i18n lint [IMPROVE] User gets feedback when a message has been starred or unstarred (#13860) [FIX] admin can sort users by email in directory view (#15796) [FIX] Pinned messages wouldn't collapse (#16188) [IMPROVE] Added border to page header. (#16792) [FIX] Correct thread messages display in context bar. (#16835) [FIX] Public channel cannot be acessed via URL when 'Allow Anonymous Read' is active (#16914) Fixed Line break incorrectly being called apostrophe (#16918) [IMPROVE] Context menu autofocus (#16915) Improve room types usage (#16753) [NEW] API `users.deactivateIdle` for mass-disabling of idle users (#16849) [NEW] API to logout from other locations (#16193) [IMPROVE] Add option to require authentication on user's shield endpoint (#16845) [FIX] Custom OAuth Bug (#16811) [FIX] Integrations page pagination (#16838) reset package-lock to upstream Apply suggestions from code review ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16246
Before changes:
After changes: