[FIX] message count of private and public channels on the page /admin/rooms#16650
Closed
subham103 wants to merge 1 commit intoRocketChat:developfrom
Closed
[FIX] message count of private and public channels on the page /admin/rooms#16650subham103 wants to merge 1 commit intoRocketChat:developfrom
subham103 wants to merge 1 commit intoRocketChat:developfrom
Conversation
|
|
Member
|
Hey, why did you open #16680 ? It's almost the same thing, you can update the current branch and comments (like if you need to link a PR that will be closed). I'll close this as I made some small changes in the other one :) Thanks for your contrib! |
Contributor
Author
|
@gabriellsh actually, first I worked on this issue, later I find out there is a similar issue which requires this issue to be solved. After all these two issues got resolved ✌️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #12610
Previously, upon deletion/prune messages, the message count on the page https://xxxxxx/admin/rooms remains the same as the previous value.
now decreased the value of the message count variable for the roomId in which the message is being deleted/pruned.
after changes
1) delete message
count before deleting one message:- 7
count after deleting one message:- 6
2) prune message(user: subham sahoo)
count before pruning one message:- 6
count after pruning one message:- 2