Skip to content

Comments

[FIX] Additional scroll when contextual bar is open#16667

Merged
ggazzo merged 3 commits intodevelopfrom
fix/contextual_bar_scroll
Feb 20, 2020
Merged

[FIX] Additional scroll when contextual bar is open#16667
ggazzo merged 3 commits intodevelopfrom
fix/contextual_bar_scroll

Conversation

@gabriellsh
Copy link
Member

When the content from the contextual bar is bigger than its container, an additional scroll bar for the entire room would appear.

image

@tassoevan tassoevan requested a review from ggazzo February 20, 2020 18:50
@tassoevan tassoevan added area: ui Touches the code on client side type: bug labels Feb 20, 2020
@tassoevan tassoevan added this to the 3.0.2 milestone Feb 20, 2020
@ggazzo ggazzo merged commit 6caed95 into develop Feb 20, 2020
@ggazzo ggazzo deleted the fix/contextual_bar_scroll branch February 20, 2020 18:54
@sampaiodiego sampaiodiego modified the milestones: 3.0.2, 3.1.0 Feb 20, 2020
gabriellsh added a commit that referenced this pull request Feb 21, 2020
…use_scrollableArea

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  [FIX] ie11 support (#16682)
  Regression: Show upload errors (#16681)
  [FIX] Delete messages while searching bug (#16568)
  Use insertSync
  [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (#16416)
  [FIX] Added an option to pin/unpin a thread message by admin (#16457)
  [CHORE] Look for Storybook stories on `app/` too (#16595)
  [IMPROVE] Removed the 'reply in thread' from thread replies (#16630)
  [FIX] Changed Opt_In message (#16631)
  [FIX] LDAP sync admin action was not syncing exisent users (#16671)
  [IMPROVE] Check agent status when starting a new conversation with an agent assigned (#16618)
  [FIX] Additional scroll when contextual bar is open (#16667)
  [FIX] Clear unread red line when the ESC key is pressed (#16668)
  [FIX] users.info endpoint not handling the error if the user does not exist (#16495)
  [NEW] Save default filters in the Omnichannel Current Chats list (#16653)
  Update app/utils/client/lib/RestApiClient.js
  Update app/utils/client/lib/RestApiClient.js
  send files over rest api
  [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot
  Improved isSingular function
  ...
gabriellsh added a commit to subham103/Rocket.Chat that referenced this pull request Feb 21, 2020
…6680-subham103-fixMessageCountStatistics

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  [FIX] ie11 support (RocketChat#16682)
  Regression: Show upload errors (RocketChat#16681)
  [FIX] Delete messages while searching bug (RocketChat#16568)
  Use insertSync
  [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (RocketChat#16416)
  [FIX] Added an option to pin/unpin a thread message by admin (RocketChat#16457)
  [CHORE] Look for Storybook stories on `app/` too (RocketChat#16595)
  [IMPROVE] Removed the 'reply in thread' from thread replies (RocketChat#16630)
  [FIX] Changed Opt_In message (RocketChat#16631)
  [FIX] LDAP sync admin action was not syncing exisent users (RocketChat#16671)
  [IMPROVE] Check agent status when starting a new conversation with an agent assigned (RocketChat#16618)
  [FIX] Additional scroll when contextual bar is open (RocketChat#16667)
  [FIX] Clear unread red line when the ESC key is pressed (RocketChat#16668)
  [FIX] users.info endpoint not handling the error if the user does not exist (RocketChat#16495)
  Update app/utils/client/lib/RestApiClient.js
  Update app/utils/client/lib/RestApiClient.js
  send files over rest api
  [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot
  Improved isSingular function
  Add message_pruned and file_pruned for singular file or message deleted
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants