[FIX] Remove spaces from i18n placeholders to show Personal access token#16724
Merged
sampaiodiego merged 2 commits intoRocketChat:developfrom Mar 10, 2020
harakiwi1:fix/placeholders-spaces
Merged
[FIX] Remove spaces from i18n placeholders to show Personal access token#16724sampaiodiego merged 2 commits intoRocketChat:developfrom harakiwi1:fix/placeholders-spaces
sampaiodiego merged 2 commits intoRocketChat:developfrom
harakiwi1:fix/placeholders-spaces
Conversation
gabriellsh
approved these changes
Feb 28, 2020
|
|
sampaiodiego
changed the title
gabriellsh
added a commit
to ritwizsinha/Rocket.Chat
that referenced
this pull request
Mar 11, 2020
…6537-ritwizsinha-Issue#16499 * 'develop' of github.com:RocketChat/Rocket.Chat: (173 commits) [FIX] No settings to be displayed if search not found (RocketChat#16255) [FIX] Removed some hardcoded texts (RocketChat#16304) [FIX] Cannot unfollow message from thread's panel (RocketChat#16560) Add Enterprise Edition license (RocketChat#16801) [FIX] Fallback content-type as application/octet-stream for FileSystem uploads (RocketChat#16776) [IMPROVE] Apps-engine E2E tests (RocketChat#16781) [FIX] Remove spaces from i18n placeholders to show Personal access token (RocketChat#16724) [NEW] SAML config to allow clock drift (RocketChat#16751) [FIX] Slash command preview: Wrong item being selected, Horizontal scroll (RocketChat#16750) [FIX] Cannot pin on direct messages (RocketChat#16759) [FIX] Get all channels from Slack via REST API (RocketChat#16767) LingoHub Update 🚀 (RocketChat#16837) [FIX] Flextab information is not working when clicking on visitor or agent username in Omnichannel messages (RocketChat#16797) Update Node to 12.16.1 [NEW] Update Meteor to 1.9.2 (RocketChat#16718) [FIX] Slackbridge-import command doesn't work (RocketChat#16645) Fix omnichannel icon missing on sidebar (RocketChat#16775) [IMPROVE] Rename client-side term "Livechat" to "Omnichannel" (RocketChat#16752) [FIX] Language country has been ignored on translation load (RocketChat#16757) [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744) ...
gabriellsh
added a commit
that referenced
this pull request
Mar 13, 2020
…exact_search * 'develop' of github.com:RocketChat/Rocket.Chat: (178 commits) [IMPROVE] Add option to require authentication on user's shield endpoint (#16845) [FIX] Custom OAuth Bug (#16811) [FIX] Integrations page pagination (#16838) fix: livechat/facebook missing visitor data after registerGuest (#16810) [FIX] Invite links counting users already joined (#16591) [FIX] No settings to be displayed if search not found (#16255) [FIX] Removed some hardcoded texts (#16304) [FIX] Cannot unfollow message from thread's panel (#16560) Add Enterprise Edition license (#16801) [FIX] Fallback content-type as application/octet-stream for FileSystem uploads (#16776) [IMPROVE] Apps-engine E2E tests (#16781) [FIX] Remove spaces from i18n placeholders to show Personal access token (#16724) [NEW] SAML config to allow clock drift (#16751) [FIX] Slash command preview: Wrong item being selected, Horizontal scroll (#16750) [FIX] Cannot pin on direct messages (#16759) [FIX] Get all channels from Slack via REST API (#16767) LingoHub Update 🚀 (#16837) [FIX] Flextab information is not working when clicking on visitor or agent username in Omnichannel messages (#16797) Update Node to 12.16.1 [NEW] Update Meteor to 1.9.2 (#16718) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16716
Remove spaces from placeholders in some i18n files. This caused placeholders not being replaced, thus users can not view their generated Personal Access Tokens.