[NEW][Apps] Remove TS compiler#18687
Merged
sampaiodiego merged 6 commits intodevelopfrom Oct 26, 2020
Merged
Conversation
This was referenced Aug 26, 2020
Contributor
|
LGTM |
shiqimei
previously approved these changes
Oct 16, 2020
Member
Author
|
We still need to change the URL we're going to use to download the apps from the Marketplace, as there will be a new one serving only the compiled version. |
d-gubert
commented
Oct 19, 2020
2fcf19d to
af33207
Compare
geekgonecrazy
previously approved these changes
Oct 25, 2020
sampaiodiego
approved these changes
Oct 26, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This removes the compilation process for the apps from Rocket.Chat. From this point on, we're expecting the apps package to contain their compiled versions already.
This is just part of the project - most of the work will be done on other packages.
Apps-Engine PR: RocketChat/Rocket.Chat.Apps-engine#307
Code is reviewable, we're figuring out what Rocket.Chat version it should be released in, as it requires other operational changes in the Marketplace API (that's why this is still a draft)
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments