Skip to content

[NEW][Apps] Remove TS compiler#18687

Merged
sampaiodiego merged 6 commits intodevelopfrom
apps/remove-ts-compiler
Oct 26, 2020
Merged

[NEW][Apps] Remove TS compiler#18687
sampaiodiego merged 6 commits intodevelopfrom
apps/remove-ts-compiler

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Aug 26, 2020

Proposed changes

This removes the compilation process for the apps from Rocket.Chat. From this point on, we're expecting the apps package to contain their compiled versions already.

This is just part of the project - most of the work will be done on other packages.

Apps-Engine PR: RocketChat/Rocket.Chat.Apps-engine#307

Code is reviewable, we're figuring out what Rocket.Chat version it should be released in, as it requires other operational changes in the Marketplace API (that's why this is still a draft)

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@thassiov
Copy link
Contributor

LGTM

shiqimei
shiqimei previously approved these changes Oct 16, 2020
@d-gubert d-gubert added this to the 3.8.0 milestone Oct 16, 2020
@d-gubert
Copy link
Member Author

We still need to change the URL we're going to use to download the apps from the Marketplace, as there will be a new one serving only the compiled version.

@d-gubert d-gubert force-pushed the apps/remove-ts-compiler branch from 2fcf19d to af33207 Compare October 24, 2020 18:43
@d-gubert d-gubert marked this pull request as ready for review October 24, 2020 18:48
@d-gubert d-gubert changed the title [NEW][Apps-Engine] Remove TS compiler [NEW][Apps] Remove TS compiler Oct 24, 2020
geekgonecrazy
geekgonecrazy previously approved these changes Oct 25, 2020
@sampaiodiego sampaiodiego merged commit 25c3457 into develop Oct 26, 2020
@sampaiodiego sampaiodiego deleted the apps/remove-ts-compiler branch October 26, 2020 16:23
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments