[FIX] Adding Custom Fields to show on user info check#20955
Merged
ggazzo merged 11 commits intoRocketChat:developfrom May 12, 2021
Merged
[FIX] Adding Custom Fields to show on user info check#20955ggazzo merged 11 commits intoRocketChat:developfrom
ggazzo merged 11 commits intoRocketChat:developfrom
Conversation
Member
Author
|
@dougfabris Please review. :) Added try catch block in case user enters wrong json, json.parse can return error. |
Member
Author
|
@ggazzo Please review. |
ggazzo
requested changes
Mar 22, 2021
6 tasks
dougfabris
requested changes
May 11, 2021
yash-rajpal
force-pushed
the
fix-custom-fields-userInfo
branch
from
c9c5188 to
fb6c4c0
Compare
|
This pull request introduces 1 alert when merging 4fecad5 into 82243ad - view on LGTM.com new alerts:
|
tassoevan
requested changes
May 11, 2021
tassoevan
approved these changes
May 12, 2021
ggazzo
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The setting custom fields to show under user info was not being used when rendering fields in user info. This pr adds those checks and only renders the fields mentioned under in admin -> accounts -> Custom Fields to Show in User Info.
Issue(s)
Custom Fields to Show in User Info was not being used
#18953
Steps to test or reproduce
Further comments