[IMPROVE] Pass allowDiskUse to channel aggregations on engagement dashboard#22374
Merged
sampaiodiego merged 3 commits intodevelopfrom May 9, 2022
Merged
Conversation
sampaiodiego
requested changes
Jun 16, 2021
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
please use read preference to secondaries
sampaiodiego
requested changes
Jun 17, 2021
sampaiodiego
requested changes
Jun 28, 2021
|
|
Member
|
hi @KevLehman , I'm sorry, can you please revert the change using |
Member
Author
|
revert to what type of |
Member
|
I think revert to this commit 12e34fe |
KevLehman
force-pushed
the
fix/allowdiskuse-on-channel-engagment-dashboard
branch
from
a207b58 to
80c8f9d
Compare
Member
Author
|
wtf |
Member
Author
|
@sampaiodiego , do you think it would be worth to make all aggs to run on secondaries? 👀 (maybe not all, but the majority of them) |
sampaiodiego
approved these changes
May 9, 2022
that is definitely worth to do! big performance improvement! |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments