[FIX] Prevent users to edit an existing role when adding a new one with the same name used before.#22407
Merged
pierre-lehnen-rc merged 26 commits intodevelopfrom Sep 24, 2021
Merged
Conversation
pierre-lehnen-rc
previously approved these changes
Jul 16, 2021
4c294e1 to
23ea82d
Compare
pierre-lehnen-rc
previously approved these changes
Jul 28, 2021
Contributor
|
The tests are going to pass once #22799 is merged; |
pierre-lehnen-rc
requested changes
Aug 3, 2021
pierre-lehnen-rc
approved these changes
Sep 24, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
before
after
Issue(s)
Steps to test or reproduce
Notes for QA
We replaced all of the methods to manipulate the roles. Would be nice to include some tests like:
Further comments