Skip to content

Comments

Chore: Move callbacks to /lib#23456

Merged
ggazzo merged 8 commits intodevelopfrom
chore/move-callbacks-module
Jan 5, 2022
Merged

Chore: Move callbacks to /lib#23456
ggazzo merged 8 commits intodevelopfrom
chore/move-callbacks-module

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Oct 13, 2021

Proposed changes (including videos or screenshots)

It moves to /lib, migrates to TypeScript, and deprecates the callbacks API.

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan force-pushed the chore/move-callbacks-module branch 2 times, most recently from 9217ab0 to 19d5219 Compare October 18, 2021 13:40
@tassoevan tassoevan marked this pull request as ready for review October 18, 2021 16:33
@tassoevan tassoevan requested a review from a team October 18, 2021 16:35
@tassoevan tassoevan force-pushed the chore/move-callbacks-module branch from 6b2a05c to 49efc9f Compare January 5, 2022 05:18
@tassoevan tassoevan force-pushed the chore/move-callbacks-module branch from 49efc9f to 083bc5f Compare January 5, 2022 05:42
@tassoevan tassoevan marked this pull request as draft January 5, 2022 06:29
@tassoevan tassoevan changed the title Chore: Move callbacks to /lib/ Chore: Move callbacks to /lib Jan 5, 2022
@tassoevan tassoevan changed the title Chore: Move callbacks to /lib Chore: Move callbacks to /lib Jan 5, 2022
@RocketChat RocketChat deleted a comment from CLAassistant Jan 5, 2022
@tassoevan tassoevan marked this pull request as ready for review January 5, 2022 19:55
@tassoevan tassoevan requested review from a team January 5, 2022 19:55
@ggazzo ggazzo merged commit 4b408c2 into develop Jan 5, 2022
@ggazzo ggazzo deleted the chore/move-callbacks-module branch January 5, 2022 20:51
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants