Skip to content

Comments

Regression: Fix Alpine release tag#24259

Merged
sampaiodiego merged 4 commits intodevelopfrom
fix-alpine-release-tag
Jan 26, 2022
Merged

Regression: Fix Alpine release tag#24259
sampaiodiego merged 4 commits intodevelopfrom
fix-alpine-release-tag

Conversation

@sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

The code was still relying in GIT_TAG that was removed in latest changes.

Issue(s)

Steps to test or reproduce

Further comments

@debdutdeb
Copy link
Member

Why not use GITHUB_REF_NAME or github.ref_name instead? I see GIT_TAG being used in a lot of places.

@sampaiodiego
Copy link
Member Author

Why not use GITHUB_REF_NAME or github.ref_name instead? I see GIT_TAG being used in a lot of places.

I think the concern was that GITHUB_REF_NAME can be also the branch name, but since we have the condition github.event_name == 'release' it should be safe using it.

maybe we can switch.. not an issue.

@debdutdeb
Copy link
Member

I guess to make sure github.event.release.tag_name should also work.

@sampaiodiego
Copy link
Member Author

sampaiodiego commented Jan 25, 2022

pushed a change to use GITHUB_REF_NAME :)

added some debug echos as well..

@sampaiodiego sampaiodiego requested a review from a team January 26, 2022 14:28
@sampaiodiego sampaiodiego merged commit 114b195 into develop Jan 26, 2022
@sampaiodiego sampaiodiego deleted the fix-alpine-release-tag branch January 26, 2022 16:51
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants