Skip to content

Comments

Regression: Fix Default Business hour overriding other Business Hours#24288

Merged
murtaza98 merged 3 commits intodevelopfrom
reg/omni-bh
Jan 26, 2022
Merged

Regression: Fix Default Business hour overriding other Business Hours#24288
murtaza98 merged 3 commits intodevelopfrom
reg/omni-bh

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Jan 25, 2022

Proposed changes (including videos or screenshots)

Issue(s)

There was a bug introduced in this PR - #24112

Steps to test or reproduce

Assumption: Business Hour is activated & is set to multiple

  1. An agent "xyz" is associated with Department A.
  2. Make Business Hours for Department A are closed.
  3. Make sure "Default Business Hour" is open
  4. Login as an agent "xyz" from Department A.
  5. Click on the omnichannel icon to make the agent available.

Expected Behaviour: Agent shouldn't be allowed to make themself available

Actual Behaviour: Agents are able to make themself available

Further comments

@murtaza98 murtaza98 requested a review from a team January 25, 2022 16:19
@murtaza98 murtaza98 merged commit e1059c1 into develop Jan 26, 2022
@murtaza98 murtaza98 deleted the reg/omni-bh branch January 26, 2022 03:43
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants