refactor: unused code by tassoevan · Pull Request #33869 · RocketChat/Rocket.Chat

tassoevan · 2024-11-02T02:11:09Z

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot · 2024-11-02T02:11:13Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2024-11-02T02:11:13Z

⚠️ No Changeset found

Latest commit: 0aae0ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-11-02T02:15:45Z

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33869/
on branch `gh-pages` at 2024-11-04 03:16 UTC

codecov · 2024-11-02T02:16:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.42%. Comparing base (3db5690) to head (0aae0ff).
⚠️ Report is 1999 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33869   +/-   ##
========================================
  Coverage    75.42%   75.42%           
========================================
  Files          493      493           
  Lines        21499    21494    -5     
  Branches      5337     5336    -1     
========================================
- Hits         16215    16212    -3     
+ Misses        4644     4642    -2     
  Partials       640      640

Flag	Coverage Δ
unit	`∅ <100.00%> (∅)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pierre-lehnen-rc · 2024-11-04T16:35:56Z

apps/meteor/server/lib/http/call.ts

@@ -1,204 +0,0 @@
-import { serverFetch as fetch } from '@rocket.chat/server-fetch';


This file was used to override Meteor's HTTP.call (#25022), but the override was removed on #28825, by mistake.
We should either reapply this override, or replace any remaining calls to HTTP with fetch.

pierre-lehnen-rc · 2024-11-04T16:37:29Z

apps/meteor/server/models/raw/Reports.ts

@@ -1,21 +0,0 @@
-import type { IMessage, IReport, RocketChatRecordDeleted } from '@rocket.chat/core-typings';


Model was replaced by a new one in #28962, it's alright to remove this one now.

pierre-lehnen-rc · 2024-11-04T16:46:58Z

apps/meteor/ee/app/livechat-enterprise/server/hooks/autoCloseQueued.ts

@@ -1,21 +0,0 @@
-import { settings } from '../../../../../app/settings/server';


File introduced by #23392, never got imported on the first place.
However, it was forgotten by mistake and is supposed to be imported instead of removed.

pierre-lehnen-rc · 2024-11-04T16:53:35Z

.../client/views/room/contextualBar/NotificationPreferences/NotificationPreferencesWithData.tsx

 import { useRoomToolbox } from '../../contexts/RoomToolboxContext';
 import NotificationPreferences from './NotificationPreferences';

-export type NotificationFormValues = {


Stopped being used on #29113, ok to remove.

pierre-lehnen-rc · 2024-11-04T16:59:18Z

apps/meteor/client/views/omnichannel/queueList/hooks/useQuery.ts

@@ -1,52 +0,0 @@
-import type { ILivechatAgent, ILivechatDepartment } from '@rocket.chat/core-typings';


Usage removed by #29594, ok to remove.

pierre-lehnen-rc · 2024-11-04T17:02:39Z

apps/meteor/app/api/server/definition.ts

 	readonly logger: Logger;
 };

-export type UserInfo = IUser & {


Hadn't been used since before this file was created, ok to remove.

pierre-lehnen-rc · 2024-11-04T17:07:50Z

apps/meteor/app/cloud/server/functions/getWorkspaceAccessToken.ts

 	return token;
 }

-export const generateWorkspaceBearerHttpHeaderOrThrow = async (


Made obsolete by #30401 on the same day it was introduced by #30178

tassoevan force-pushed the refactor/unused-code branch 2 times, most recently from 15c3b8d to 9bda431 Compare November 2, 2024 04:27

tassoevan added 10 commits November 4, 2024 00:11

Remove duplicated exports

91a932d

Remove unused type exports

95143c6

Remove unused modules

4220385

Remove unused modules

48807a5

Remove duplicated exports

2ab2d9d

Fix migrations

c40691a

Add missing explicit dependencies

79f0270

Remove unused exports

716eef9

Remove unused exports

ad25359

Revert some exports for unit tests

ed00c95

tassoevan force-pushed the refactor/unused-code branch from 9bda431 to ed00c95 Compare November 4, 2024 03:11

Delete unreferenced model

0aae0ff

pierre-lehnen-rc requested changes Nov 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: unused code#33869

refactor: unused code#33869
tassoevan wants to merge 11 commits intodevelopfrom
refactor/unused-code

tassoevan commented Nov 2, 2024

Uh oh!

dionisio-bot bot commented Nov 2, 2024

Uh oh!

changeset-bot bot commented Nov 2, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 2, 2024 •

edited

Loading

Uh oh!

codecov bot commented Nov 2, 2024 •

edited

Loading

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,204 +0,0 @@
		import { serverFetch as fetch } from '@rocket.chat/server-fetch';

		@@ -1,21 +0,0 @@
		import type { IMessage, IReport, RocketChatRecordDeleted } from '@rocket.chat/core-typings';

		@@ -1,21 +0,0 @@
		import { settings } from '../../../../../app/settings/server';

		@@ -1,52 +0,0 @@
		import type { ILivechatAgent, ILivechatDepartment } from '@rocket.chat/core-typings';

Comments

Conversation

tassoevan commented Nov 2, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

dionisio-bot bot commented Nov 2, 2024

Uh oh!

changeset-bot bot commented Nov 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Nov 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

pierre-lehnen-rc Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Nov 2, 2024 •

edited

Loading

github-actions bot commented Nov 2, 2024 •

edited

Loading

codecov bot commented Nov 2, 2024 •

edited

Loading