From c6ba9680a632c196ce8a695b2a48ff2071eddac9 Mon Sep 17 00:00:00 2001
From: Andrew Scholer <ascholer@chemeketa.edu>
Date: Wed, 22 Mar 2023 07:07:04 -0700
Subject: [PATCH 1/7] Get rid of col-md-12 in interactives

Was there from an experiment with code/output side/side
---
 runestone/activecode/activecode.py      | 2 +-
 runestone/activecode/css/activecode.css | 4 ----
 runestone/activecode/js/activecode.js   | 7 ++-----
 runestone/common/js/presenter_mode.js   | 2 +-
 runestone/hparsons/hparsons.py          | 2 +-
 runestone/hparsons/js/SQLFeedback.js    | 2 +-
 runestone/hparsons/js/hparsons.js       | 1 -
 7 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/runestone/activecode/activecode.py b/runestone/activecode/activecode.py
index d565ff78f..34d974c1f 100644
--- a/runestone/activecode/activecode.py
+++ b/runestone/activecode/activecode.py
@@ -87,7 +87,7 @@ def setup(app):
 TEMPLATE_START = """
 <div class="%(divclass)s %(optclass)s">
 <div data-component="activecode" id=%(divid)s data-question_label="%(question_label)s">
-<div id=%(divid)s_question class="ac_question col-md-12">
+<div id=%(divid)s_question class="ac_question">
 """
 
 TEMPLATE_END = """
diff --git a/runestone/activecode/css/activecode.css b/runestone/activecode/css/activecode.css
index 36475353c..719ab4561 100644
--- a/runestone/activecode/css/activecode.css
+++ b/runestone/activecode/css/activecode.css
@@ -102,10 +102,6 @@
     border: 2px solid black;
 }
 
-.ac_section > .col-md-12 {
-    max-width: 100% !important;
-}
-
 .full_width ol {
     max-width: 100% !important;
 }
diff --git a/runestone/activecode/js/activecode.js b/runestone/activecode/js/activecode.js
index c4610ab2d..968ec6219 100755
--- a/runestone/activecode/js/activecode.js
+++ b/runestone/activecode/js/activecode.js
@@ -159,7 +159,7 @@ export class ActiveCode extends RunestoneBase {
         var linkdiv = document.createElement("div");
         linkdiv.id = this.divid.replace(/_/g, "-").toLowerCase(); // :ref: changes _ to - so add this as a target
         var codeDiv = document.createElement("div");
-        $(codeDiv).addClass("ac_code_div col-md-12");
+        $(codeDiv).addClass("ac_code_div");
         this.codeDiv = codeDiv;
         this.outerDiv.lang = this.language;
         $(this.origElem).replaceWith(this.outerDiv);
@@ -286,7 +286,6 @@ export class ActiveCode extends RunestoneBase {
         var ctrlDiv = document.createElement("div");
         var butt;
         $(ctrlDiv).addClass("ac_actions");
-        $(ctrlDiv).addClass("col-md-12");
         // Run
         butt = document.createElement("button");
         $(butt).text($.i18n("msg_activecode_run_code"));
@@ -703,7 +702,7 @@ export class ActiveCode extends RunestoneBase {
         // to hold turtle graphics output.  We use a div in case the turtle changes from
         // using a canvas to using some other element like svg in the future.
         var outDiv = document.createElement("div");
-        $(outDiv).addClass("ac_output col-md-12");
+        $(outDiv).addClass("ac_output");
         this.outDiv = outDiv;
         this.output = document.createElement("pre");
         this.output.id = this.divid + "_stdout";
@@ -731,12 +730,10 @@ export class ActiveCode extends RunestoneBase {
         this.outerDiv.appendChild(outDiv);
         var lensDiv = document.createElement("div");
         lensDiv.id = `${this.divid}_codelens`;
-        $(lensDiv).addClass("col-md-12");
         $(lensDiv).css("display", "none");
         this.codelens = lensDiv;
         this.outerDiv.appendChild(lensDiv);
         var coachDiv = document.createElement("div");
-        $(coachDiv).addClass("col-md-12");
         $(coachDiv).css("display", "none");
         this.codecoach = coachDiv;
         this.outerDiv.appendChild(coachDiv);
diff --git a/runestone/common/js/presenter_mode.js b/runestone/common/js/presenter_mode.js
index d7277d2ec..5edb6da06 100644
--- a/runestone/common/js/presenter_mode.js
+++ b/runestone/common/js/presenter_mode.js
@@ -138,7 +138,7 @@ function codelensListener(duration) {
 function configureCodelens() {
     let acCodeTitle = document.createElement("h4");
     acCodeTitle.textContent = "Active Code Window";
-    let acCode = $(".ac_code_div").removeClass("col-md-12");
+    let acCode = $(".ac_code_div");
     $(".ac_code_div").addClass("col-md-6");
     acCode.prepend(acCodeTitle);
 
diff --git a/runestone/hparsons/hparsons.py b/runestone/hparsons/hparsons.py
index 1971d288d..a0b69672a 100755
--- a/runestone/hparsons/hparsons.py
+++ b/runestone/hparsons/hparsons.py
@@ -39,7 +39,7 @@ def setup(app):
 TEMPLATE_START = """
 <div class="runestone">
 <div data-component="hparsons" id=%(divid)s data-question_label="%(question_label)s" class="alert alert-warning hparsons_section">
-<div class="hp_question col-md-12">
+<div class="hp_question">
 """
 
 TEMPLATE_END = """
diff --git a/runestone/hparsons/js/SQLFeedback.js b/runestone/hparsons/js/SQLFeedback.js
index 55b5ca097..7cb0163cb 100644
--- a/runestone/hparsons/js/SQLFeedback.js
+++ b/runestone/hparsons/js/SQLFeedback.js
@@ -9,7 +9,7 @@ export default class SQLFeedback extends HParsonsFeedback {
 
     createOutput() {
         var outDiv = document.createElement("div");
-        $(outDiv).addClass("hp_output col-md-12");
+        $(outDiv).addClass("hp_output");
         this.outDiv = outDiv;
         this.output = document.createElement("pre");
         this.output.id = this.hparsons.divid + "_stdout";
diff --git a/runestone/hparsons/js/hparsons.js b/runestone/hparsons/js/hparsons.js
index e242ef91b..30f903f15 100644
--- a/runestone/hparsons/js/hparsons.js
+++ b/runestone/hparsons/js/hparsons.js
@@ -125,7 +125,6 @@ export default class HParsons extends RunestoneBase {
     createControls() {
         var ctrlDiv = document.createElement("div");
         $(ctrlDiv).addClass("hp_actions");
-        $(ctrlDiv).addClass("col-md-12");
 
         // Run Button
         this.runButton = document.createElement("button");

From 8f3eea2e0aaab36943eea3796e92f0736659988a Mon Sep 17 00:00:00 2001
From: Andrew Scholer <ascholer@chemeketa.edu>
Date: Wed, 22 Mar 2023 07:07:38 -0700
Subject: [PATCH 2/7] Margin tweaks for activecode

---
 runestone/activecode/css/activecode.css | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/runestone/activecode/css/activecode.css b/runestone/activecode/css/activecode.css
index 719ab4561..30936129e 100644
--- a/runestone/activecode/css/activecode.css
+++ b/runestone/activecode/css/activecode.css
@@ -67,6 +67,7 @@
 
 .ac_output {
     margin-top: 10px;
+    margin-bottom: -10px;
     display: none;
     background-color: inherit;
 }
@@ -146,3 +147,7 @@
     margin-bottom: 10px;
     min-height: 0px !important;
 }
+
+.codelens {
+    margin-bottom: 20px;
+}
\ No newline at end of file

From c7206fdd1deacf749f5f7346f5c690944ada06fc Mon Sep 17 00:00:00 2001
From: Andrew Scholer <ascholer@chemeketa.edu>
Date: Wed, 22 Mar 2023 07:08:16 -0700
Subject: [PATCH 3/7] Activecode - remove useless divs. Add class to codelens
 and codecoach divs

---
 runestone/activecode/js/activecode.js | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/runestone/activecode/js/activecode.js b/runestone/activecode/js/activecode.js
index 968ec6219..a6f060f70 100755
--- a/runestone/activecode/js/activecode.js
+++ b/runestone/activecode/js/activecode.js
@@ -722,24 +722,20 @@ export class ActiveCode extends RunestoneBase {
                 $(this.graphics).addClass("visible-ac-canvas");
             }.bind(this)
         );
-        var clearDiv = document.createElement("div");
-        $(clearDiv).css("clear", "both"); // needed to make parent div resize properly
-        this.outerDiv.appendChild(clearDiv);
         outDiv.appendChild(this.output);
         outDiv.appendChild(this.graphics);
         this.outerDiv.appendChild(outDiv);
         var lensDiv = document.createElement("div");
+        lensDiv.classList.add("codelens");
         lensDiv.id = `${this.divid}_codelens`;
         $(lensDiv).css("display", "none");
         this.codelens = lensDiv;
         this.outerDiv.appendChild(lensDiv);
         var coachDiv = document.createElement("div");
+        coachDiv.classList.add("codecoach");
         $(coachDiv).css("display", "none");
         this.codecoach = coachDiv;
         this.outerDiv.appendChild(coachDiv);
-        clearDiv = document.createElement("div");
-        $(clearDiv).css("clear", "both"); // needed to make parent div resize properly
-        this.outerDiv.appendChild(clearDiv);
     }
 
     disableSaveLoad() {

From 7edee14ea180cfcaf096c46e678121c1ad1ec4e3 Mon Sep 17 00:00:00 2001
From: Andrew Scholer <ascholer@chemeketa.edu>
Date: Wed, 22 Mar 2023 07:09:05 -0700
Subject: [PATCH 4/7] Remove alignVertical from activecode

---
 runestone/activecode/js/acfactory.js       |  3 ---
 runestone/activecode/js/activecode.js      |  1 -
 runestone/activecode/js/activecode_html.js | 13 -------------
 3 files changed, 17 deletions(-)

diff --git a/runestone/activecode/js/acfactory.js b/runestone/activecode/js/acfactory.js
index 9f907eed9..40051f1fa 100644
--- a/runestone/activecode/js/acfactory.js
+++ b/runestone/activecode/js/acfactory.js
@@ -86,9 +86,6 @@ export default class ACFactory {
             sid: sid,
             graderactive: true,
         };
-        if (language === "htmlmixed") {
-            addopts["vertical"] = true;
-        }
         newac = ACFactory.createActiveCode(thepre, language, addopts);
         var savediv = newac.divid;
         newac.divid = savediv;
diff --git a/runestone/activecode/js/activecode.js b/runestone/activecode/js/activecode.js
index a6f060f70..4c382928c 100755
--- a/runestone/activecode/js/activecode.js
+++ b/runestone/activecode/js/activecode.js
@@ -63,7 +63,6 @@ export class ActiveCode extends RunestoneBase {
         this.containerDiv = opts.orig;
         this.useRunestoneServices = opts.useRunestoneServices;
         this.python3 = true;
-        this.alignVertical = opts.vertical;
         this.origElem = orig;
         this.origText = this.origElem.textContent;
         this.divid = opts.orig.id;
diff --git a/runestone/activecode/js/activecode_html.js b/runestone/activecode/js/activecode_html.js
index 5912bd588..c6844789a 100644
--- a/runestone/activecode/js/activecode_html.js
+++ b/runestone/activecode/js/activecode_html.js
@@ -3,7 +3,6 @@ import { ActiveCode } from "./activecode.js";
 export default class HTMLActiveCode extends ActiveCode {
     constructor(opts) {
         super(opts);
-        opts.alignVertical = true;
         this.code = $("<textarea />").html(this.origElem.innerHTML).text();
         $(this.runButton).text("Render");
         this.editor.setValue(this.code);
@@ -14,12 +13,6 @@ export default class HTMLActiveCode extends ActiveCode {
         let saveCode = "True";
         this.saveCode = await this.manage_scrubber(saveCode);
         $(this.output).text("");
-        if (!this.alignVertical) {
-            $(this.codeDiv).switchClass("col-md-12", "col-md-6", {
-                duration: 500,
-                queue: false,
-            });
-        }
         $(this.outDiv).show({ duration: 700, queue: false });
         prog =
             "<script type=text/javascript>window.onerror = function(msg,url,line) {alert(msg+' on line: '+line);};</script>" +
@@ -28,14 +21,8 @@ export default class HTMLActiveCode extends ActiveCode {
     }
 
     createOutput() {
-        this.alignVertical = true;
         var outDiv = document.createElement("div");
         $(outDiv).addClass("ac_output");
-        if (this.alignVertical) {
-            $(outDiv).addClass("col-md-12");
-        } else {
-            $(outDiv).addClass("col-md-5");
-        }
         this.outDiv = outDiv;
         this.output = document.createElement("iframe");
         $(this.output).css("background-color", "white");

From bd74a568332b0eb9f757f24c57a3493cdcbf2502 Mon Sep 17 00:00:00 2001
From: Andrew Scholer <ascholer@chemeketa.edu>
Date: Thu, 6 Apr 2023 18:22:08 -0700
Subject: [PATCH 5/7] Refactor Pyflakes code coach

---
 runestone/activecode/js/activecode-i18n.en.js |  1 +
 runestone/activecode/js/activecode.js         | 52 ++++++++++++++-----
 .../activecode/js/coach-python-pyflakes.js    | 50 ++++++++++++++++++
 3 files changed, 91 insertions(+), 12 deletions(-)
 create mode 100644 runestone/activecode/js/coach-python-pyflakes.js

diff --git a/runestone/activecode/js/activecode-i18n.en.js b/runestone/activecode/js/activecode-i18n.en.js
index 6bdd4fc07..6bf1f3b6a 100644
--- a/runestone/activecode/js/activecode-i18n.en.js
+++ b/runestone/activecode/js/activecode-i18n.en.js
@@ -114,5 +114,6 @@ $.i18n().load({
         msg_activecode_assertion_error_fix:
             "Check the expression to the right of assert.  The expression is False and you will need to determine why that is.  You may want to simply print out the individual parts of the expression to understand why it is evaluating to False.",
         msg_activecode_load_db: "Loading DB...",
+        msg_activecode_code_coach: "Code Coach",
     },
 });
diff --git a/runestone/activecode/js/activecode.js b/runestone/activecode/js/activecode.js
index 957f1222b..0e133706e 100755
--- a/runestone/activecode/js/activecode.js
+++ b/runestone/activecode/js/activecode.js
@@ -30,6 +30,7 @@ import "codemirror/addon/hint/anyword-hint.js";
 import "codemirror/addon/edit/matchbrackets.js";
 import "./skulpt.min.js";
 import "./skulpt-stdlib.js";
+import PyflakesCoach from "./coach-python-pyflakes.js";
 // Used by Skulpt.
 import embed from "vega-embed";
 // Adapt for use outside webpack -- see https://github.com/vega/vega-embed.
@@ -65,6 +66,7 @@ export class ActiveCode extends RunestoneBase {
         this.python3 = true;
         this.origElem = orig;
         this.origText = this.origElem.textContent;
+        this.codeCoachList = [];    //list of CodeCoaches that will be used to provide feedback
         this.divid = opts.orig.id;
         this.code = $(orig).text() || "\n\n\n\n\n";
         this.language = $(orig).data("lang");
@@ -92,7 +94,7 @@ export class ActiveCode extends RunestoneBase {
         }
         this.output = null; // create pre for output
         this.graphics = null; // create div for turtle graphics
-        this.codecoach = null;
+        this.codecoach = null; // div for Code Coaches
         this.codelens = null;
         this.controlDiv = null;
         this.historyScrubber = null;
@@ -137,6 +139,12 @@ export class ActiveCode extends RunestoneBase {
             this.caption = "ActiveCode";
         }
         this.addCaption("runestone");
+
+        //Setup CodeCoaches - add based on language
+        if (this.language == "python" || this.language == "python3") {
+            this.codeCoachList.push(new PyflakesCoach());
+        }
+
         setTimeout(
             function () {
                 this.editor.refresh();
@@ -274,6 +282,7 @@ export class ActiveCode extends RunestoneBase {
         if (this.logResults) {
             this.logCurrentAnswer();
         }
+        this.runCoaches();
         this.renderFeedback();
         // The run is finished; re-enable the button.
         this.runButton.disabled = false;
@@ -722,15 +731,11 @@ export class ActiveCode extends RunestoneBase {
             }.bind(this)
         );
 
-        //Anything that wants to add output to coachdiv can do so after the h3
-        // all those elements will be cleared with each run and coach display will be
-        // reset to none. Any component that adds content after a run should set display
-        // to block to ensure visibility
         var coachDiv = document.createElement("div");
         coachDiv.classList.add("alert", "alert-warning", "codecoach");
         $(coachDiv).css("display", "none");
         let coachHead = coachDiv.appendChild(document.createElement("h3"));
-        coachHead.textContent = "Code Coach";
+        coachHead.textContent = $.i18n("msg_activecode_code_coach");
         this.outerDiv.appendChild(coachDiv);
         this.codecoach = coachDiv;
 
@@ -1222,6 +1227,35 @@ Yet another is that there is an internal error.  The internal error message is:
         }
     }
 
+    async runCoaches() {
+        //Run all available code coaches and update code coach div
+
+        //clear anything after header in codecoach div and hide it
+        $(this.codecoach).children().slice(1).remove();
+        $(this.codecoach).css("display", "none");
+
+        //get code, run coaches
+        let code = await this.buildProg(false);
+        let results = [];
+        for(let coach of this.codeCoachList) {
+            results.push(coach.check(code));
+        }
+
+        //once all coaches are done, update div
+        Promise.allSettled(results).then((promises) => {
+            for(let p of promises) {
+                if(p.status === 'fulfilled' && p.value != null) {
+                    let checkDiv = document.createElement("div");
+                    checkDiv.classList.add("python_check_results");
+                    let checkPre = checkDiv.appendChild(document.createElement("pre"));
+                    checkPre.textContent = p.value;
+                    this.codecoach.append(checkDiv);
+                    $(this.codecoach).css("display", "block");
+                }
+            }
+        });
+    }
+
     renderFeedback() {
         // The python unit test code builds the table as it is running the tests
         // In "normal" usage this is displayed immediately.
@@ -1342,9 +1376,6 @@ Yet another is that there is an internal error.  The internal error message is:
         this.saveCode = "True";
         $(this.output).text("");
 
-        //clear anything after header in codecoach
-        $(this.codecoach).children().slice(1).remove();
-
         while ($(`#${this.divid}_errinfo`).length > 0) {
             $(`#${this.divid}_errinfo`).remove();
         }
@@ -1386,9 +1417,6 @@ Yet another is that there is an internal error.  The internal error message is:
                 queue: false,
             });
         }
-        if (this.language == "python" || this.language == "python3") {
-            this.checkPythonSyntax();
-        }
         try {
             await Sk.misceval.asyncToPromise(function () {
                 return Sk.importMainWithBody("<stdin>", false, prog, true);
diff --git a/runestone/activecode/js/coach-python-pyflakes.js b/runestone/activecode/js/coach-python-pyflakes.js
new file mode 100644
index 000000000..c0875e4e5
--- /dev/null
+++ b/runestone/activecode/js/coach-python-pyflakes.js
@@ -0,0 +1,50 @@
+$.i18n().load({
+    en: {
+        msd_pyflakes_coach_line: "Line",
+    },
+});
+
+export default class PyflakesCoach {
+    async check(code) {
+        let promise = new Promise(function (resolve, reject) {
+            fetch('/ns/coach/python_check', {
+                method: 'POST',
+                body: code
+            })
+            .then((response) => {
+                return response.json();
+            })
+            .then((data) => {
+                if(data.trim() !== '') {
+                    let message = "";
+                    //clean up returned text
+                    let errorLines = data.split("\n");
+                    let codeLines = code.split("\n");
+                    for(let line of errorLines) {
+                        if(line.indexOf(".py:") != -1) {
+                            //old pyflakes returns "file:line:col error"
+                            //new pyflakes returns "file:line:col: error"
+                            //handle either
+                            const cleaner = /[^.]*.py:(\d+):(\d+):? (.*)/i;
+                            let lineParts = line.match(cleaner)
+                            
+                            message += $.i18n("msd_pyflakes_coach_line") + lineParts[1] + ": " + lineParts[3] + "\n";
+                            message += codeLines[lineParts[1] - 1] + "\n";
+                            message += " ".repeat(lineParts[2] - 1) + "^\n";
+                        } else {
+                            message += line + "\n";
+                        }
+                    }
+                    message = message.slice(0,-1);  //remove trailing newline
+                    resolve(message);
+                }
+                resolve(null);
+            })
+            .catch(err => {
+                reject("Error in Pyflakes Coach: " + err);
+            })
+        });
+        return promise;
+    }
+}
+

From 30982ff81a5136bf7501560ea2921aa8eb620ddb Mon Sep 17 00:00:00 2001
From: Andrew Scholer <ascholer@chemeketa.edu>
Date: Thu, 6 Apr 2023 19:32:26 -0700
Subject: [PATCH 6/7] Remove old checkPythonSyntax

---
 runestone/activecode/js/activecode.js | 45 ---------------------------
 1 file changed, 45 deletions(-)

diff --git a/runestone/activecode/js/activecode.js b/runestone/activecode/js/activecode.js
index 0e133706e..635f6980e 100755
--- a/runestone/activecode/js/activecode.js
+++ b/runestone/activecode/js/activecode.js
@@ -1305,51 +1305,6 @@ Yet another is that there is an internal error.  The internal error message is:
         }
     }
 
-    async checkPythonSyntax() {
-        let code = this.editor.getValue();
-        fetch('/ns/coach/python_check', {
-            method: 'POST',
-            body: code
-        })
-        .then((response) => {
-            return response.json();
-        })
-        .then((data) => {
-            if(data.trim() !== '') {
-                //clean up returned text
-                let errorLines = data.split("\n");
-                let codeLines = code.split("\n");
-                let message = "";
-                for(let line of errorLines) {
-                    if(line.indexOf(".py:") != -1) {
-                        //old pyflakes returns "file:line:col error"
-                        //new pyflakes returns "file:line:col: error"
-                        //handle either
-                        const cleaner = /[^.]*.py:(\d+):(\d+):? (.*)/i;
-                        let lineParts = line.match(cleaner)
-                        message += "Line " + lineParts[1] + ": " + lineParts[3] + "\n";
-                        message += codeLines[lineParts[1] - 1] + "\n";
-                        message += " ".repeat(lineParts[2] - 1) + "^\n";
-                    } else {
-                        message += line + "\n";
-                    }
-                }
-                message = message.slice(0,-1);  //remove trailing newline
-
-                //Render
-                let checkDiv = document.createElement("div");
-                checkDiv.classList.add("python_check_results");
-                let checkPre = checkDiv.appendChild(document.createElement("pre"));
-                checkPre.textContent = message;
-                this.codecoach.append(checkDiv);
-                $(this.codecoach).css("display", "block");
-            }
-        })
-        .catch(err => {
-            console.log("Error with ajax python check:", err);
-        });
-    }
-
     /* runProg has several async elements to it.
      * 1. Skulpt runs the python program asynchronously
      * 2. The history is restored asynchronously

From 180192ea4ed388cd1d937324f6d328d6dbfc2b06 Mon Sep 17 00:00:00 2001
From: Andrew Scholer <ascholer@chemeketa.edu>
Date: Fri, 7 Apr 2023 13:45:21 -0700
Subject: [PATCH 7/7] Filter "import *" related messages in Pyflakes code coach

---
 runestone/activecode/js/activecode.js            |  2 +-
 runestone/activecode/js/coach-python-pyflakes.js | 13 +++++++++----
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/runestone/activecode/js/activecode.js b/runestone/activecode/js/activecode.js
index 635f6980e..8806b29bb 100755
--- a/runestone/activecode/js/activecode.js
+++ b/runestone/activecode/js/activecode.js
@@ -1244,7 +1244,7 @@ Yet another is that there is an internal error.  The internal error message is:
         //once all coaches are done, update div
         Promise.allSettled(results).then((promises) => {
             for(let p of promises) {
-                if(p.status === 'fulfilled' && p.value != null) {
+                if(p.status === 'fulfilled' && p.value !== null && p.value.trim() !== "") {
                     let checkDiv = document.createElement("div");
                     checkDiv.classList.add("python_check_results");
                     let checkPre = checkDiv.appendChild(document.createElement("pre"));
diff --git a/runestone/activecode/js/coach-python-pyflakes.js b/runestone/activecode/js/coach-python-pyflakes.js
index c0875e4e5..3fc305a6c 100644
--- a/runestone/activecode/js/coach-python-pyflakes.js
+++ b/runestone/activecode/js/coach-python-pyflakes.js
@@ -26,11 +26,16 @@ export default class PyflakesCoach {
                             //new pyflakes returns "file:line:col: error"
                             //handle either
                             const cleaner = /[^.]*.py:(\d+):(\d+):? (.*)/i;
-                            let lineParts = line.match(cleaner)
+                            let lineParts = line.match(cleaner);  //[1]: line, [2]: col, [3]: error
                             
-                            message += $.i18n("msd_pyflakes_coach_line") + lineParts[1] + ": " + lineParts[3] + "\n";
-                            message += codeLines[lineParts[1] - 1] + "\n";
-                            message += " ".repeat(lineParts[2] - 1) + "^\n";
+                            //for now, filter messages about star imports
+                            if(!lineParts[3].includes("defined from star imports") 
+                            && !lineParts[3].includes("*' used; unable to detect undefined names"))
+                            {
+                                message += $.i18n("msd_pyflakes_coach_line") + lineParts[1] + ": " + lineParts[3] + "\n";
+                                message += codeLines[lineParts[1] - 1] + "\n";
+                                message += " ".repeat(lineParts[2] - 1) + "^\n";
+                            }
                         } else {
                             message += line + "\n";
                         }