From c76a25acee71ee51b1b8a11b52fda124d3d424d0 Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.co> Date: Mon, 25 Oct 2021 19:13:48 +0000 Subject: [PATCH 1/2] fixes #490 --- src/checks/y_check_prefer_returning.clas.abap | 1 + ...eck_prefer_returning.clas.testclasses.abap | 32 +++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/src/checks/y_check_prefer_returning.clas.abap b/src/checks/y_check_prefer_returning.clas.abap index 33bac180..294f4210 100644 --- a/src/checks/y_check_prefer_returning.clas.abap +++ b/src/checks/y_check_prefer_returning.clas.abap @@ -62,6 +62,7 @@ CLASS y_check_prefer_returning IMPLEMENTATION. OR -str = 'RETURNING' OR -str = 'RAISING'. skip = abap_true. + CLEAR count. ELSEIF -str = 'EXPORTING'. skip = abap_false. ENDIF. diff --git a/src/checks/y_check_prefer_returning.clas.testclasses.abap b/src/checks/y_check_prefer_returning.clas.testclasses.abap index 0ef8b36f..1c4ec80b 100644 --- a/src/checks/y_check_prefer_returning.clas.testclasses.abap +++ b/src/checks/y_check_prefer_returning.clas.testclasses.abap @@ -213,3 +213,35 @@ CLASS ltc_standard_table IMPLEMENTATION. ENDMETHOD. ENDCLASS. + + + +CLASS ltc_export_and_returning DEFINITION INHERITING FROM ltc_one_exporting FOR TESTING RISK LEVEL HARMLESS DURATION SHORT. + PROTECTED SECTION. + METHODS get_code_without_issue REDEFINITION. +ENDCLASS. + +CLASS ltc_export_and_returning IMPLEMENTATION. + + METHOD get_code_without_issue. + result = VALUE #( + ( 'REPORT y_example. ' ) + + ( ' START-OF-SELECTION. ' ) + ( ' CLASS example DEFINITION. ' ) + ( ' PUBLIC SECTION. ' ) + ( ' METHODS run ' ) + ( ' EXPORTING ' ) + ( ' !error TYPE char1 ' ) + ( ' RETURNING ' ) + ( ' VALUE(result) TYPE string_table. "#EC NUM_OUTPUT_PARA ' ) + ( ' ENDCLASS. ' ) + + ( ' CLASS example IMPLEMENTATION. ' ) + ( ' METHOD run. ' ) + ( ' ENDMETHOD. ' ) + ( ' ENDCLASS. ' ) + ). + ENDMETHOD. + +ENDCLASS. From 5b780cb90309f7b3c9652cc233fc4d972db37ff0 Mon Sep 17 00:00:00 2001 From: Lucas Borin <5233413+lucasborin@users.noreply.github.com> Date: Mon, 25 Oct 2021 16:14:59 -0300 Subject: [PATCH 2/2] changelog --- changelog.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/changelog.txt b/changelog.txt index 1dc38fc3..3c8ea512 100644 --- a/changelog.txt +++ b/changelog.txt @@ -18,6 +18,7 @@ Legend 2021-08-XX v.1.16.0 ------------------ +* Skip 'Prefer RETURNING to EXPORTING' when both exist (#490) * Pseudo Comment Usage: Multiple Inline Entries (#494) * Prefer Pragmas to Pseudo Comments: Multiple Pseudo Comments (#489) * Y_CHECK_MESSAGE_EASY_TO_FIND dump (#492)