From ed6fa3138c48c1b6b0151dbcc5709b8d12a1ebe3 Mon Sep 17 00:00:00 2001 From: Oliver Feldmann Date: Mon, 22 Sep 2025 10:58:30 +0200 Subject: [PATCH 1/2] chore: remove push to ghcr As we do not use this and the push needs a PAT, which we don't want to provide anymore, we deactivate this. --- .github/workflows/build.yml | 5 ----- .github/workflows/release.yml | 5 ----- 2 files changed, 10 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1a49667..2ad8076 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -26,20 +26,15 @@ jobs: - name: Build run: | docker build --build-arg=BASE_IMAGE_TAG=${{ matrix.base-image-tag }} --build-arg=JAVA_VERSION=${{ steps.java_version.outputs.version }} --tag ppiper/node-browsers:${{ matrix.base-image-tag }} . - docker tag ppiper/node-browsers:${{ matrix.base-image-tag }} ghcr.io/sap/ppiper-node-browsers:${{ matrix.base-image-tag }} - name: Tag latest image if: ${{ matrix.base-image-tag == '24-bookworm' }} run: | docker tag ppiper/node-browsers:${{ matrix.base-image-tag }} ppiper/node-browsers:latest - docker tag ghcr.io/sap/ppiper-node-browsers:${{ matrix.base-image-tag }} ghcr.io/sap/ppiper-node-browsers:latest - name: Push if: ${{ github.ref == 'refs/heads/master' }} run: | echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_USER }} --password-stdin - echo "${{ secrets.CR_PAT }}" | docker login https://ghcr.io -u ${{ secrets.CR_USER }} --password-stdin docker push ppiper/node-browsers:${{ matrix.base-image-tag }} - docker push ghcr.io/sap/ppiper-node-browsers:${{ matrix.base-image-tag }} if [ "${{ matrix.base-image-tag }}" == 24-bookworm ]; then docker push ppiper/node-browsers:latest - docker push ghcr.io/sap/ppiper-node-browsers:latest fi diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 418c387..a8a918c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -39,18 +39,13 @@ jobs: - name: Build and push run: | echo ${{ secrets.DOCKERHUB_PASSWORD }} | docker login -u ${{ secrets.DOCKERHUB_USER }} --password-stdin - echo "${{ secrets.CR_PAT }}" | docker login https://ghcr.io -u ${{ secrets.CR_USER }} --password-stdin docker build --build-arg=BASE_IMAGE_TAG=${{ matrix.base-image-tag }} --build-arg=JAVA_VERSION=${{ steps.java_version.outputs.version }} --tag ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} . - docker tag ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} docker push ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} - docker push ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} - name: Tag and push node 24 image if: ${{ matrix.base-image-tag == '24-bookworm' }} run: | docker tag ppiper/node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} ppiper/node-browsers:${{ env.PIPER_version }} - docker tag ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }}-${{ matrix.base-image-tag }} ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }} docker push ppiper/node-browsers:${{ env.PIPER_version }} - docker push ghcr.io/sap/ppiper-node-browsers:${{ env.PIPER_version }} - uses: SAP/project-piper-action@master if: ${{ matrix.base-image-tag == '24-bookworm' }} with: From 8017c151f0d7d43dc873e291317dfe397bc606fe Mon Sep 17 00:00:00 2001 From: Oliver Feldmann Date: Tue, 3 Mar 2026 14:28:44 +0100 Subject: [PATCH 2/2] chore: add readme entry --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 1d8d801..16e06b2 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,8 @@ [![REUSE status](https://api.reuse.software/badge/github.com/SAP/devops-docker-node-browsers)](https://api.reuse.software/info/github.com/SAP/devops-docker-node-browsers) +> **⚠️ Important Notice:** The GitHub Container Registry (ghcr.io) for this project is no longer being updated. Please use the Docker Hub registry instead: `docker pull ppiper/node-browsers` + This [_Dockerfile_](https://docs.docker.com/engine/reference/builder/) can be used in _Continuous Delivery_ (CD) pipelines for SAP development projects. The image is optimized for use with project ["Piper"](https://github.com/SAP/jenkins-library) on [Jenkins](https://jenkins.io/). Docker containers simplify your CD tool setup, encapsulating tools and environments that are required to execute pipeline steps.