From d6a9469de7e50e4a4d4c3f5a0d0bd93552f95953 Mon Sep 17 00:00:00 2001 From: gputnam Date: Mon, 26 Feb 2024 16:22:13 -0600 Subject: [PATCH 1/2] Fix bug in MCS producer. --- sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.cxx b/sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.cxx index cd0b4c53f..c16aeea1a 100644 --- a/sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.cxx +++ b/sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.cxx @@ -33,7 +33,7 @@ recob::MCSFitResult TrajectoryMCSFitter::fitMcs(const recob::TrackTrajectory& tr if (segradlengths[p]<-100. || segradlengths[p-1]<-100.) { dtheta.push_back(-999.); } - if (!breakpointsgood[p] || !breakpointsgood[p-1]) { + else if (!breakpointsgood[p] || !breakpointsgood[p-1]) { dtheta.push_back(-999.); } else { @@ -391,4 +391,4 @@ bool TrajectoryMCSFitter::isInVolume(const std::vector &volu } } return false; -} \ No newline at end of file +} From ebaf50606851213c62d379e0d8fa24fe52fbe997 Mon Sep 17 00:00:00 2001 From: gputnam Date: Mon, 26 Feb 2024 16:22:35 -0600 Subject: [PATCH 2/2] Update ICARUS FV and Monte Carlo angular resultion. --- sbncode/LArRecoProducer/mcsproducer_icarus.fcl | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/sbncode/LArRecoProducer/mcsproducer_icarus.fcl b/sbncode/LArRecoProducer/mcsproducer_icarus.fcl index 4926fdfc7..53bff0a85 100644 --- a/sbncode/LArRecoProducer/mcsproducer_icarus.fcl +++ b/sbncode/LArRecoProducer/mcsproducer_icarus.fcl @@ -1,13 +1,21 @@ BEGIN_PROLOG -mcs_sbn: { +mcs_icarus_data: { module_type: MCSFitAllPID MCS: { eLossMode: 2 - angResol: 10.0 + angResol: 10.0 # tuned to data fiducialVolumeInsets: [10.0, 10.0, 10.0, 10.0, 10.0, 10.0] - excludeVolumes: [190.0, 240.0, -9999.0, 9999.0, -9999.0, 9999.0] + excludeVolumes: [ + 200.0, 221.0, -9999.0, 9999.0, -9999.0, 9999.0, # exclude 10cm around cathode in Cryo W + -221.0, -200.0, -9999.0, 9999.0, -9999.0, 9999.0, # exclude 10cm around cathode in Cryo E + 210.29, 358.49, 70, 9999.0, 0, 9999.0, # exclude dangling cable in TPC WW -- cut 65cm from top + -358.49, -210.29, 115, 9999.0, -9999.0, 9999.0 # exclude field cage failure in TPC EE -- cut 20cm from top + ] } TrackLabel: pandoraTrack } +mcs_icarus_mc: @local::mcs_icarus_data +mcs_icarus_mc.MCS.angResol: 3.0 # tuned to MC + END_PROLOG