From 12d6599a9c5cd68edc7cf56f739a37f3e1242a63 Mon Sep 17 00:00:00 2001 From: Jeremy Wildfire Date: Mon, 6 Jun 2022 16:05:00 -0400 Subject: [PATCH] fix #680 --- R/evaluateStandard.R | 2 +- tests/testthat/test_evaluateStandard.R | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/R/evaluateStandard.R b/R/evaluateStandard.R index 55c8a128..0b7c78b9 100644 --- a/R/evaluateStandard.R +++ b/R/evaluateStandard.R @@ -46,7 +46,7 @@ evaluateStandard <- function(data, meta, domain, standard){ compare_summary<-list() compare_summary[["standard"]]<-standard - domainMeta<-meta %>% filter(domain==!!domain) + domainMeta<-meta %>% filter(tolower(domain)==!!domain) standardMap <- domainMeta%>%pull(paste0("standard_",!!standard)) names(standardMap)<-domainMeta%>%pull(.data$text_key) compare_summary[["mapping"]] <- domainMeta %>% diff --git a/tests/testthat/test_evaluateStandard.R b/tests/testthat/test_evaluateStandard.R index a446b6ed..32489521 100644 --- a/tests/testthat/test_evaluateStandard.R +++ b/tests/testthat/test_evaluateStandard.R @@ -42,4 +42,10 @@ test_that("invalid options throw errors",{ expect_error(evaluateStandard(data=safetyData::adam_adlbc,domain="labs", meta=safetyCharts::meta_labs, standard="adam", includeFieldsIsNotAnOptionNow="yesPlease")) expect_error(evaluateStandard(data=safetyData::adam_adlbc,domain="labs", meta=list(), standard="sdtm")) expect_error(evaluateStandard(data=safetyData::adam_adlbc,domain="labs", meta=safetyData::adam_adlbc, standard="sdtm")) +}) + + +test_that("upper case domain names are supported",{ + uppermeta <- safetyCharts::meta_labs %>% mutate(domain="LaBs") + expect_equal(evaluateStandard(data=safetyData::adam_adlbc, domain="lAbS", meta= uppermeta, standard="adam")[["match"]],"full") }) \ No newline at end of file