Merged
Conversation
Merged
|
Is it worth adding a test that captures current dask behaviour? That way, when it fails (iris uses a dask release with the fix), it will be obvious to remove the workaround. Or alternatively a known failure test. |
Contributor
Author
|
@cpelley That makes sense |
pelson
approved these changes
Oct 27, 2017
| self.assertMaskedArrayEqual(result, a) | ||
|
|
||
| def test_dask_scalar_proxy_pass_through(self): | ||
| # This test will fail when using a version of Dask with |
Member
There was a problem hiding this comment.
A little bit naughty (hello future person who is going back and reading this PR).
| res = ma.masked_array(res.data, mask=res.mask) | ||
| return res | ||
|
|
||
| _getall_delayed = dask.delayed(_getall) |
Member
There was a problem hiding this comment.
There is a decorator for this purpose...
This was referenced Dec 18, 2017
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for dask/dask#2823 (now fixed on dask/master), identified in #2861.