From d78b77c87a83226a85dbe741c77faabfa52571bd Mon Sep 17 00:00:00 2001 From: Peleg Wainberg Date: Wed, 25 Mar 2020 16:18:42 +0200 Subject: [PATCH 1/2] Add feedback #2 --- .management/feedback/2 | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .management/feedback/2 diff --git a/.management/feedback/2 b/.management/feedback/2 new file mode 100644 index 0000000..5054b2f --- /dev/null +++ b/.management/feedback/2 @@ -0,0 +1,14 @@ +Peleg Wainberg - + +Existing stages suggestions: +Stage 5: Changed to 66, opened a PR to ShayNehmad/sylvanly-narrower-oxboy, travis gave me the flag. Felt wrong so I re-did the stage. +Stage 7: The face that only part of the tag name is the next stage's branch name was unclear. Also, I think it's too "passive" - it's very clear that I only need to find the tag name of a given commit. +Stage 9: the loop adds 102 files lol. Also, the hook will always return 1 - was that on purpose? +Stage 10: I didn't even have to read the hook to pass. Maybe make people write a hook and validate it? + +Other Suggestions: +- Add a git bisect stage! it can be cool (and not that hard). Easy part can be manually finding the bad commit, Advanced part can be writing a script that finds it and letting git bisect to the work for you! +- Add people to the leaderboard automatically! +- Add a more advanced rebase exercises. +- Add stages for squash, ammend, reset (different types). Maybe something for stash, restore, clean + \ No newline at end of file From e375b4a144843065e6832dd530d5e5de457d616d Mon Sep 17 00:00:00 2001 From: Peleg Wainberg Date: Wed, 25 Mar 2020 16:18:08 +0200 Subject: [PATCH 2/2] Update HALLOFFAME.md --- HALLOFFAME.md | 1 + 1 file changed, 1 insertion(+) diff --git a/HALLOFFAME.md b/HALLOFFAME.md index 07aa947..b37829d 100644 --- a/HALLOFFAME.md +++ b/HALLOFFAME.md @@ -15,3 +15,4 @@ Good job, you finished the CTF! 🚩🏆 - [Daniel Goldberg](https://github.com/danielguardicore) - [Liad Mordekoviz](https://github.com/liadmord) - [Yair Shemla](https://github.com/yairshemla) +- [Peleg Wainberg](https://github.com/pelegwain)