diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index d82105cdd1c..8946d097ec8 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -22,7 +22,7 @@ jobs: strategy: matrix: os: ['ubuntu-latest'] - node: ['18.12.0'] + node: ['18.20.3'] steps: - uses: actions/checkout@v3 name: Checkout [main] diff --git a/.github/workflows/shopify-cli.yml b/.github/workflows/shopify-cli.yml index f80d4fb1302..b1b9946a86c 100644 --- a/.github/workflows/shopify-cli.yml +++ b/.github/workflows/shopify-cli.yml @@ -11,10 +11,10 @@ on: node-version: description: 'Node version' required: true - default: '18.12.0' + default: '18.20.3' type: choice options: - - 18.12.0 + - 18.20.3 - 20.14.0 - 22.2.0 os: @@ -60,7 +60,7 @@ jobs: strategy: matrix: os: ['ubuntu-latest', 'windows-latest', 'macos-latest'] - node: ['18.12.0', '20.14.0', '22.2.0'] + node: ['18.20.3', '20.14.0', '22.2.0'] steps: - uses: actions/checkout@v3 name: Checkout [${{ github.ref_name }}] @@ -72,20 +72,20 @@ jobs: node-version: ${{ matrix.node }} - name: Build run: pnpm nx run-many --all --skip-nx-cache --target=build - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }} + if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }} - name: Lint run: pnpm nx run-many --all --skip-nx-cache --target=lint - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }} + if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }} - name: Type-check run: pnpm nx run-many --all --skip-nx-cache --target=type-check - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }} + if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }} - name: Bundle run: pnpm nx run-many --all --skip-nx-cache --target=bundle - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }} + if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }} - name: Unit tests run: pnpm nx run-many --all --skip-nx-cache --target=test --exclude=features - name: Acceptance tests - if: ${{ matrix.node == '18.12.0' }} + if: ${{ matrix.node == '18.20.3' }} run: pnpm nx run features:test - name: Send Slack notification on failure uses: slackapi/slack-github-action@007b2c3c751a190b6f0f040e47ed024deaa72844 # pin@v1.23.0 @@ -99,7 +99,7 @@ jobs: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} - name: Run and save test coverage uses: ./.github/actions/run-and-save-test-coverage - if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.12.0' }} + if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.20.3' }} with: branch-name: ${{ github.ref_name }} @@ -111,7 +111,7 @@ jobs: strategy: matrix: os: ['ubuntu-latest'] - node: ['18.12.0'] + node: ['18.20.3'] target: ['build', 'type-check', 'lint'] steps: - uses: actions/checkout@v3 @@ -134,7 +134,7 @@ jobs: strategy: matrix: os: ['ubuntu-latest'] - node: ['18.12.0'] + node: ['18.20.3'] steps: - uses: actions/checkout@v3 with: @@ -158,7 +158,7 @@ jobs: strategy: matrix: os: ['ubuntu-latest'] - node: ['18.12.0'] + node: ['18.20.3'] steps: - uses: actions/checkout@v3 with: @@ -188,7 +188,7 @@ jobs: - name: Setup deps uses: ./.github/actions/setup-cli-deps with: - node-version: 18.12.0 + node-version: 18.20.3 - name: Build run: pnpm build - name: Refresh manifests @@ -216,7 +216,7 @@ jobs: strategy: matrix: os: ['ubuntu-latest', 'windows-latest', 'macos-latest'] - node: ['18.12.0', '20.14.0', '22.2.0'] + node: ['18.20.3', '20.14.0', '22.2.0'] steps: - uses: actions/checkout@v3 with: @@ -238,7 +238,7 @@ jobs: strategy: matrix: os: ['ubuntu-latest', 'macos-latest', 'windows-latest'] - node: ['18.12.0'] + node: ['18.20.3'] steps: - uses: actions/checkout@v3 with: @@ -260,7 +260,7 @@ jobs: strategy: matrix: os: ['ubuntu-latest'] - node: ['18.12.0'] + node: ['18.20.3'] steps: - uses: actions/checkout@v3 with: diff --git a/packages/cli/package.json b/packages/cli/package.json index 4af5279d0c5..11b64949ad7 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -120,7 +120,7 @@ "vitest": "^0.34.3" }, "engines": { - "node": ">=18.12.0" + "node": ">=18.20.0" }, "os": [ "darwin",