From 675df9b913c0c1908d5ded13a80911ca0514c049 Mon Sep 17 00:00:00 2001 From: alex Date: Mon, 27 Oct 2025 11:47:13 +0200 Subject: [PATCH 1/2] [MS-1213] Creating separate UI layouts for landscape orientation for tablets and phones. This way all UI elements are reachable and visible on the screen --- .../ExternalCredentialScanOcrFragment.kt | 4 +- .../fragment_external_credential_scan_ocr.xml | 133 ++++++++++++++++++ .../fragment_external_credential_scan_qr.xml | 97 +++++++++++++ .../fragment_external_credential_scan_ocr.xml | 131 +++++++++++++++++ .../fragment_external_credential_scan_qr.xml | 95 +++++++++++++ .../fragment_external_credential_scan_ocr.xml | 2 +- 6 files changed, 459 insertions(+), 3 deletions(-) create mode 100644 feature/external-credential/src/main/res/layout-land/fragment_external_credential_scan_ocr.xml create mode 100644 feature/external-credential/src/main/res/layout-land/fragment_external_credential_scan_qr.xml create mode 100644 feature/external-credential/src/main/res/layout-sw600dp-land/fragment_external_credential_scan_ocr.xml create mode 100644 feature/external-credential/src/main/res/layout-sw600dp-land/fragment_external_credential_scan_qr.xml diff --git a/feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt b/feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt index 33957a011c..beb779dbde 100644 --- a/feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt +++ b/feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt @@ -213,7 +213,7 @@ internal class ExternalCredentialScanOcrFragment : Fragment(R.layout.fragment_ex instructionsText.text = getString(IDR.string.mfid_scan_instructions, documentTypeText) instructionsText.setTextColor(ContextCompat.getColor(requireContext(), IDR.color.simprints_text_white)) documentScannerArea.isVisible = true - progressContainer.isVisible = false + progressContainer.isInvisible = true buttonScan.isVisible = true buttonScan.setOnClickListener { viewModel.ocrStarted() @@ -238,7 +238,7 @@ internal class ExternalCredentialScanOcrFragment : Fragment(R.layout.fragment_ex private fun renderNoPermission(shouldOpenPhoneSettings: Boolean) { with(binding) { instructionsText.isVisible = false - progressContainer.isVisible = false + progressContainer.isInvisible = true documentScannerArea.isInvisible = true buttonScan.isVisible = false val documentTypeText = viewModel.getDocumentTypeRes().run(::getString) diff --git a/feature/external-credential/src/main/res/layout-land/fragment_external_credential_scan_ocr.xml b/feature/external-credential/src/main/res/layout-land/fragment_external_credential_scan_ocr.xml new file mode 100644 index 0000000000..8553b5231d --- /dev/null +++ b/feature/external-credential/src/main/res/layout-land/fragment_external_credential_scan_ocr.xml @@ -0,0 +1,133 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + +