From c1c09f65a02359c4f4d933f595234c532c610811 Mon Sep 17 00:00:00 2001 From: alex Date: Wed, 11 Feb 2026 11:59:51 +0200 Subject: [PATCH 1/2] =?UTF-8?q?Cherry=20picking=20latest=20linter=20rules?= =?UTF-8?q?=CB=86=20from=20the=20main=20branch?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .editorconfig | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.editorconfig b/.editorconfig index 9446997321..d740210478 100644 --- a/.editorconfig +++ b/.editorconfig @@ -19,9 +19,22 @@ ktlint_standard_annotation = disabled # If enabled, this rules forces any multiline assignment to the new line regardless of length ktlint_standard_multiline-expression-wrapping = disabled +# If enabled, this rules forces braces to all branches if any single one has them +ktlint_standard_when-entry-bracing = disabled + +# If enabled, this rule forces blank line between when branches if there is a single multiline branch +ktlint_standard_blank-line-between-when-conditions = disabled +ij_kotlin_line_break_after_multiline_when_entry = false + # Default allows the expression body to be a single call to a wrapper # function (e.g. `runTest{}`) without a line break ktlint_function_signature_body_expression_wrapping = default # In tests star imports are fine since there could be lots helper functions ij_kotlin_packages_to_use_import_on_demand=androidx.test.**,io.mockk.**,com.google.common.truth.** + +# Backticked function names are only used in tests and those names can be very long +ktlint_ignore_back_ticked_identifier=true + +# Unused import deletion is disabled by default due to a issue with +ktlint_standard_no-unused-imports = enabled From 26e4513669c23bd84eb0ad1840f0d71ca5c7a339 Mon Sep 17 00:00:00 2001 From: alex Date: Wed, 11 Feb 2026 12:58:31 +0200 Subject: [PATCH 2/2] [MS-1338] Removing checkbox from the credential confirmation --- .../view/ScannedCredentialDialog.kt | 5 ----- .../res/layout/dialog_scanned_credential.xml | 18 ++++++------------ 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/feature/external-credential/src/main/java/com/simprints/feature/externalcredential/view/ScannedCredentialDialog.kt b/feature/external-credential/src/main/java/com/simprints/feature/externalcredential/view/ScannedCredentialDialog.kt index 9fd5837eff..ad996aef1a 100644 --- a/feature/external-credential/src/main/java/com/simprints/feature/externalcredential/view/ScannedCredentialDialog.kt +++ b/feature/external-credential/src/main/java/com/simprints/feature/externalcredential/view/ScannedCredentialDialog.kt @@ -52,11 +52,6 @@ class ScannedCredentialDialog( documentField.text = credentialField title.text = context.getString(IDR.string.mfid_add_document_title, credential) credentialValue.text = displayedCredential.value - confirmCredentialCheckbox.text = - context.getString(IDR.string.mfid_confirmation_checkbox_text, credentialField) - confirmCredentialCheckbox.setOnCheckedChangeListener { _, isChecked -> - buttonConfirm.isEnabled = isChecked - } buttonSkip.setOnClickListener { onSkip() } buttonConfirm.setOnClickListener { onConfirm() } } diff --git a/feature/external-credential/src/main/res/layout/dialog_scanned_credential.xml b/feature/external-credential/src/main/res/layout/dialog_scanned_credential.xml index 5a1ec274d8..4ee42c7014 100644 --- a/feature/external-credential/src/main/res/layout/dialog_scanned_credential.xml +++ b/feature/external-credential/src/main/res/layout/dialog_scanned_credential.xml @@ -49,22 +49,17 @@ style="@style/Text.Headline4.Bold" android:layout_width="match_parent" android:layout_height="wrap_content" + android:layout_marginBottom="@dimen/margin_huge" android:layout_marginEnd="@dimen/margin_large" android:paddingHorizontal="@dimen/margin_large" android:textColor="@color/simprints_text_black" tools:text="GHA-123456789-0" /> - +