From a3340d361d39bd0d57737bc29327f1cc2dd4f7b4 Mon Sep 17 00:00:00 2001 From: Sergejs Luhmirins Date: Tue, 2 Sep 2025 18:06:31 +0300 Subject: [PATCH 1/2] MS-1137 Add deviceId and app version fields to the response data --- .../java/com/simprints/libsimprints/Constants.kt | 3 +++ .../libsimprints/contracts/SimprintsResponse.kt | 4 ++++ .../libsimprints/contracts/VersionsList.kt | 5 +++++ .../contracts/SimprintsResponseTest.kt | 14 ++++++++++++++ 4 files changed, 26 insertions(+) diff --git a/src/main/java/com/simprints/libsimprints/Constants.kt b/src/main/java/com/simprints/libsimprints/Constants.kt index b2744ec..c14b147 100644 --- a/src/main/java/com/simprints/libsimprints/Constants.kt +++ b/src/main/java/com/simprints/libsimprints/Constants.kt @@ -97,6 +97,9 @@ object Constants { const val SIMPRINTS_COSYNC_EVENT = "events" const val SIMPRINTS_COSYNC_SUBJECT_ACTIONS = "subjectActions" + const val SIMPRINTS_DEVICE_ID = "deviceId" + const val SIMPRINTS_APP_VERSION_NAME = "appVersionName" + @Deprecated( "Use SIMPRINTS_ENROL_INTENT instead", replaceWith = ReplaceWith("SIMPRINTS_ENROL_INTENT"), diff --git a/src/main/java/com/simprints/libsimprints/contracts/SimprintsResponse.kt b/src/main/java/com/simprints/libsimprints/contracts/SimprintsResponse.kt index d47773b..5df35db 100644 --- a/src/main/java/com/simprints/libsimprints/contracts/SimprintsResponse.kt +++ b/src/main/java/com/simprints/libsimprints/contracts/SimprintsResponse.kt @@ -24,6 +24,8 @@ data class SimprintsResponse( val resultCode: Int, val biometricsComplete: Boolean = false, val sessionId: String? = null, + val deviceId: String? = null, + val appVersionName: String? = null, // Request-specific data - only one field will be non-null val enrolment: Enrolment? = null, val verification: Verification? = null, @@ -53,6 +55,8 @@ data class SimprintsResponse( false, ), sessionId = intent.getStringExtra(Constants.SIMPRINTS_SESSION_ID), + deviceId = intent.getStringExtra(Constants.SIMPRINTS_DEVICE_ID), + appVersionName = intent.getStringExtra(Constants.SIMPRINTS_APP_VERSION_NAME), refusal = intent .getStringExtra(Constants.SIMPRINTS_REFUSAL_FORM) ?.let { RefusalForm.fromJson(it) }, diff --git a/src/main/java/com/simprints/libsimprints/contracts/VersionsList.kt b/src/main/java/com/simprints/libsimprints/contracts/VersionsList.kt index dfa0749..b9731a7 100644 --- a/src/main/java/com/simprints/libsimprints/contracts/VersionsList.kt +++ b/src/main/java/com/simprints/libsimprints/contracts/VersionsList.kt @@ -13,4 +13,9 @@ object VersionsList { * adding and removing data fields simpler. */ const val INITIAL_REWORK = 20250102 + + /** + * In this version deviceId and app version name fields were added to the response data + */ + const val ADDED_DEVICE_FIELDS = 20250200 } diff --git a/src/test/java/com/simprints/libsimprints/contracts/SimprintsResponseTest.kt b/src/test/java/com/simprints/libsimprints/contracts/SimprintsResponseTest.kt index 33f6087..98990f5 100644 --- a/src/test/java/com/simprints/libsimprints/contracts/SimprintsResponseTest.kt +++ b/src/test/java/com/simprints/libsimprints/contracts/SimprintsResponseTest.kt @@ -33,6 +33,20 @@ class SimprintsResponseTest { assertEquals(Constants.SIMPRINTS_CANCELLED, result.resultCode) } + @Test + fun `correctly parses common fields`() { + val intent: Intent = Intent().also { + it.putExtra(Constants.SIMPRINTS_SESSION_ID, "sessionId") + it.putExtra(Constants.SIMPRINTS_DEVICE_ID, "deviceId") + it.putExtra(Constants.SIMPRINTS_APP_VERSION_NAME, "version") + } + val result = SimprintsResponse.fromIntent(intent, Constants.SIMPRINTS_OK) + + assertEquals("sessionId", result.sessionId) + assertEquals("deviceId", result.deviceId) + assertEquals("version", result.appVersionName) + } + @Test fun `correctly parses error result intent`() { val intent = Intent().putExtra( From 4948d23d059507bab03acc96c4e5d60692cca328 Mon Sep 17 00:00:00 2001 From: Sergejs Luhmirins Date: Tue, 2 Sep 2025 18:06:50 +0300 Subject: [PATCH 2/2] MS-1137 Update version in the readme --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e81225f..c309e3f 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ **Installation** ``` -implementation 'com.simprints:libsimprints:2025.1.3' +implementation 'com.simprints:libsimprints:2025.2.0' ``` [Documentation](https://simprints.gitbook.io/docs/development/simprints-for-developers/integrating-with-simprints) @@ -20,5 +20,5 @@ implementation 'com.simprints:libsimprints:2025.1.3' maven("https://oss.sonatype.org/content/repositories/snapshots") // In app level gradle file -implementation 'com.simprints:libsimprints:2025.1.3-SNAPSHOT' +implementation 'com.simprints:libsimprints:2025.2.0-SNAPSHOT' ```