From 1d5e101d37d0b9767e1b7c56b32dfc18919032aa Mon Sep 17 00:00:00 2001 From: salil-naik Date: Fri, 15 Sep 2023 05:03:51 +0530 Subject: [PATCH 1/5] feat: option to add default sort preference --- src/components/Settings/SortPreference.tsx | 14 +++++--------- src/hooks/useCustomSettings.ts | 20 ++++++++++++++++---- src/types/index.d.ts | 3 +++ 3 files changed, 24 insertions(+), 13 deletions(-) diff --git a/src/components/Settings/SortPreference.tsx b/src/components/Settings/SortPreference.tsx index 24db7d3..ed108e6 100644 --- a/src/components/Settings/SortPreference.tsx +++ b/src/components/Settings/SortPreference.tsx @@ -9,10 +9,8 @@ import { SubTitle } from "./SubTitle"; export const SortPreference = () => { const dispatch = useDispatch(); - const sortPrefFromStore = useSelector((state: any) => state.quotes.sortPref); - const [_sortPref, _setSortPref] = useState(sortPrefFromStore); + const sortPref = useSelector((state: any) => state.quotes.sortPref); const [dropdown, openDropdown] = useState(false); - const [label, setLabel] = useState(""); const dropdownRef = useClickOutside(() => openDropdown(false)); @@ -32,15 +30,13 @@ export const SortPreference = () => { ]; const handleChange = (item) => { - _setSortPref(item.id); dispatch(setSortPref(item.id)); - setLabel(item.label); openDropdown(false); }; - useEffect(() => { - setLabel(sortOptions.filter((x) => x.id === _sortPref)?.[0].label); - }, []); + function getSortOption(id) { + return sortOptions.filter((x) => x.id === id)?.[0]; + } return (
@@ -51,7 +47,7 @@ export const SortPreference = () => { ref={dropdownRef} >