From bab02ab78d563696a5216ea24957985c4ae7aaad Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Thu, 27 Jan 2022 21:26:40 -0500 Subject: [PATCH 1/7] GitHub CI: Only list failed tests I am sooooooo damn tired of scrolling this list. --- .github/workflows/CI.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 32c118f8c..64438cdd3 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -36,6 +36,7 @@ jobs: name: StackExchange.Redis.Tests (Ubuntu) - Results path: 'test-results/*.trx' reporter: dotnet-trx + list-tests: 'failed' - name: .NET Lib Pack run: dotnet pack src/StackExchange.Redis/StackExchange.Redis.csproj --no-build -c Release /p:Packing=true /p:PackageOutputPath=%CD%\.nupkgs /p:CI=true @@ -82,4 +83,5 @@ jobs: with: name: StackExchange.Redis.Tests (Windows Server 2019) - Results path: 'test-results/*.trx' - reporter: dotnet-trx + reporter: dotnet-trx + list-tests: 'failed' From d6c096ea30ffc7c59bd440c62d736f8f32a4fe4f Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Thu, 27 Jan 2022 21:35:14 -0500 Subject: [PATCH 2/7] This doesn't work work Bleh. https://github.com/dorny/test-reporter/issues/142 --- .github/workflows/CI.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 64438cdd3..2fb62ed61 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -36,7 +36,7 @@ jobs: name: StackExchange.Redis.Tests (Ubuntu) - Results path: 'test-results/*.trx' reporter: dotnet-trx - list-tests: 'failed' + list-tests: failed - name: .NET Lib Pack run: dotnet pack src/StackExchange.Redis/StackExchange.Redis.csproj --no-build -c Release /p:Packing=true /p:PackageOutputPath=%CD%\.nupkgs /p:CI=true @@ -51,7 +51,6 @@ jobs: with: dotnet-version: | 3.1.x - 5.0.x 6.0.x - name: .NET Build run: dotnet build Build.csproj -c Release /p:CI=true @@ -84,4 +83,4 @@ jobs: name: StackExchange.Redis.Tests (Windows Server 2019) - Results path: 'test-results/*.trx' reporter: dotnet-trx - list-tests: 'failed' + list-tests: failed From 572590791066788c15873a80396d482192830429 Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Sat, 29 Jan 2022 12:27:36 -0500 Subject: [PATCH 3/7] Yeah that option doesn't work - need to find another test reporter --- .github/workflows/CI.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 2fb62ed61..efaaebc8f 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -36,7 +36,6 @@ jobs: name: StackExchange.Redis.Tests (Ubuntu) - Results path: 'test-results/*.trx' reporter: dotnet-trx - list-tests: failed - name: .NET Lib Pack run: dotnet pack src/StackExchange.Redis/StackExchange.Redis.csproj --no-build -c Release /p:Packing=true /p:PackageOutputPath=%CD%\.nupkgs /p:CI=true @@ -83,4 +82,3 @@ jobs: name: StackExchange.Redis.Tests (Windows Server 2019) - Results path: 'test-results/*.trx' reporter: dotnet-trx - list-tests: failed From c656010582c0c86ca206b0fe4636f6e82e72c720 Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Sat, 29 Jan 2022 12:28:11 -0500 Subject: [PATCH 4/7] Remove .NET Core 3.1 from test runs We aren't getting benefit out of this other than delays/time and more chances of socket failure in the overall. --- .github/workflows/CI.yml | 2 -- .../StackExchange.Redis.Tests/StackExchange.Redis.Tests.csproj | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index efaaebc8f..0eed3671f 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -20,7 +20,6 @@ jobs: uses: actions/setup-dotnet@v1 with: dotnet-version: | - 3.1.x 6.0.x - name: .NET Build run: dotnet build Build.csproj -c Release /p:CI=true @@ -49,7 +48,6 @@ jobs: uses: actions/setup-dotnet@v1 with: dotnet-version: | - 3.1.x 6.0.x - name: .NET Build run: dotnet build Build.csproj -c Release /p:CI=true diff --git a/tests/StackExchange.Redis.Tests/StackExchange.Redis.Tests.csproj b/tests/StackExchange.Redis.Tests/StackExchange.Redis.Tests.csproj index 5cf895e50..454e97982 100644 --- a/tests/StackExchange.Redis.Tests/StackExchange.Redis.Tests.csproj +++ b/tests/StackExchange.Redis.Tests/StackExchange.Redis.Tests.csproj @@ -1,6 +1,6 @@  - net472;netcoreapp3.1;net6.0 + net472;net6.0 StackExchange.Redis.Tests true true From d7b163f0fcf42abeaacd014cda50ee4ba41d5a80 Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Sat, 29 Jan 2022 12:33:50 -0500 Subject: [PATCH 5/7] Nuke 5.x from AppVeyor too --- appveyor.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 7387352eb..a2107f48c 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -6,8 +6,6 @@ init: install: - cmd: >- - choco install dotnet-sdk --version 5.0.404 - choco install dotnet-sdk --version 6.0.101 cd tests\RedisConfigs\3.0.503 From 84f5a947401143f6703a4175789abb3386d8b3de Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Sat, 29 Jan 2022 13:39:45 -0500 Subject: [PATCH 6/7] Shorten names! Make it easier to pick out results in the checks list. --- .github/workflows/CI.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 0eed3671f..449d1267f 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -1,4 +1,4 @@ -name: CI Builds +name: CI on: pull_request: @@ -32,7 +32,7 @@ jobs: continue-on-error: true if: success() || failure() with: - name: StackExchange.Redis.Tests (Ubuntu) - Results + name: Test Results - Ubuntu path: 'test-results/*.trx' reporter: dotnet-trx - name: .NET Lib Pack @@ -77,6 +77,6 @@ jobs: continue-on-error: true if: success() || failure() with: - name: StackExchange.Redis.Tests (Windows Server 2019) - Results + name: Tests Results - Windows Server 2019 path: 'test-results/*.trx' reporter: dotnet-trx From ca7d07313047889175a0cc4227428615cc474583 Mon Sep 17 00:00:00 2001 From: Nick Craver Date: Tue, 1 Feb 2022 20:50:17 -0500 Subject: [PATCH 7/7] Speed tweaks --- .github/workflows/CI.yml | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 449d1267f..44bd09eb6 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v1 - - name: Setup .NET Core + - name: Install .NET SDK uses: actions/setup-dotnet@v1 with: dotnet-version: | @@ -39,16 +39,18 @@ jobs: run: dotnet pack src/StackExchange.Redis/StackExchange.Redis.csproj --no-build -c Release /p:Packing=true /p:PackageOutputPath=%CD%\.nupkgs /p:CI=true windows: - name: StackExchange.Redis (Windows Server 2019) - runs-on: windows-2019 + name: StackExchange.Redis (Windows Server 2022) + runs-on: windows-2022 + env: + NUGET_CERT_REVOCATION_MODE: offline # Disabling signing because of massive perf hit, see https://github.com/NuGet/Home/issues/11548 steps: - name: Checkout code uses: actions/checkout@v1 - - name: Setup .NET Core 3.x - uses: actions/setup-dotnet@v1 - with: - dotnet-version: | - 6.0.x + # - name: Install .NET SDK + # uses: actions/setup-dotnet@v1 + # with: + # dotnet-version: | + # 6.0.x - name: .NET Build run: dotnet build Build.csproj -c Release /p:CI=true - name: Start Redis Services (v3.0.503) @@ -77,6 +79,6 @@ jobs: continue-on-error: true if: success() || failure() with: - name: Tests Results - Windows Server 2019 + name: Tests Results - Windows Server 2022 path: 'test-results/*.trx' reporter: dotnet-trx