From 2ff872f3905d3d4ca228e59c1857a04bcfdbce7c Mon Sep 17 00:00:00 2001 From: Marcel Weinberg Date: Sat, 22 Feb 2020 23:49:30 +0100 Subject: [PATCH 1/3] lookup tage values by tag.name instead of name --- st2api/st2api/controllers/v1/actions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st2api/st2api/controllers/v1/actions.py b/st2api/st2api/controllers/v1/actions.py index 792d456829..906b9aecef 100644 --- a/st2api/st2api/controllers/v1/actions.py +++ b/st2api/st2api/controllers/v1/actions.py @@ -62,7 +62,7 @@ class ActionsController(resource.ContentPackResourceController): supported_filters = { 'name': 'name', 'pack': 'pack', - 'tags': 'name' + 'tags': 'tag.name' } query_options = { From ad3b358a2a7ea790deca32df60e2fae986e780db Mon Sep 17 00:00:00 2001 From: Marcel Weinberg Date: Sat, 22 Feb 2020 23:58:26 +0100 Subject: [PATCH 2/3] add changelog entry for the fixed tag filter - #4828 --- CHANGELOG.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index aebe1b2371..f86759c50b 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -59,7 +59,10 @@ Changed Fixed ~~~~~ +* Fix the action query when filtering tags. The old implementation returned actions which have the + provided name as action name and not as tag name. #4828 + Reported by @AngryDeveloper and contributed by Marcel Weinberg (@winem) * Fix rbac with execution view where the rbac is unable to verify the pack or uid of the execution because it was not returned from the action execution db. This would result in an internal server error when trying to view the results of a single execution. From 228cdffcde720746dd46e25c9e2767b9f6005ec2 Mon Sep 17 00:00:00 2001 From: Marcel Weinberg Date: Mon, 24 Feb 2020 10:04:40 +0100 Subject: [PATCH 3/3] update changelog entry --- CHANGELOG.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index f86759c50b..84641244f9 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -60,7 +60,7 @@ Changed Fixed ~~~~~ * Fix the action query when filtering tags. The old implementation returned actions which have the - provided name as action name and not as tag name. #4828 + provided name as action name and not as tag name. (bug fix) #4828 Reported by @AngryDeveloper and contributed by Marcel Weinberg (@winem) * Fix rbac with execution view where the rbac is unable to verify the pack or uid of the execution