From ac8a82bba9f9687482d2ac8e091f0c2c352f6642 Mon Sep 17 00:00:00 2001 From: Eric Reeves Date: Mon, 14 Jun 2021 14:53:54 -0500 Subject: [PATCH 1/5] Change minimum garbage_collection TTL to 1 day from 7 --- st2common/st2common/constants/garbage_collection.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st2common/st2common/constants/garbage_collection.py b/st2common/st2common/constants/garbage_collection.py index ac8a2aac5f..735862c08f 100644 --- a/st2common/st2common/constants/garbage_collection.py +++ b/st2common/st2common/constants/garbage_collection.py @@ -28,7 +28,7 @@ DEFAULT_SLEEP_DELAY = 2 # Minimum value for the TTL. If user supplies value lower than this, we will throw. -MINIMUM_TTL_DAYS = 7 +MINIMUM_TTL_DAYS = 1 # Minimum TTL in days for action execution output objects. MINIMUM_TTL_DAYS_EXECUTION_OUTPUT = 1 From fcdeb209d391633c6139ef5f9fb49b0a67eb4d59 Mon Sep 17 00:00:00 2001 From: Eric Reeves Date: Tue, 15 Jun 2021 10:02:10 -0500 Subject: [PATCH 2/5] Update CHANGELOG for garbage collection TTL reduction --- CHANGELOG.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 75d3911233..7c7d343f26 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -263,6 +263,10 @@ Changed * Update orquesta to v1.4.0. +* Reduced minimum TTL on garbage collection for action executions and trigger instances from 7 days to 1 day. + + Contributed by @ericreeves. + Improvements ~~~~~~~~~~~~ From 815a6991aec2e603e1647c223c1cbdabf9bfc02c Mon Sep 17 00:00:00 2001 From: Eric Reeves Date: Tue, 15 Jun 2021 10:23:06 -0500 Subject: [PATCH 3/5] Specify what this TTL is actually used for --- st2common/st2common/constants/garbage_collection.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/st2common/st2common/constants/garbage_collection.py b/st2common/st2common/constants/garbage_collection.py index 735862c08f..2e56d396bd 100644 --- a/st2common/st2common/constants/garbage_collection.py +++ b/st2common/st2common/constants/garbage_collection.py @@ -27,7 +27,7 @@ # How to long to wait / sleep between collection of different object types (in seconds) DEFAULT_SLEEP_DELAY = 2 -# Minimum value for the TTL. If user supplies value lower than this, we will throw. +# Minimum TTL in days for action executions and trigger instances. MINIMUM_TTL_DAYS = 1 # Minimum TTL in days for action execution output objects. From 6e548d2044f848a95975a5db53aad5c5d2d62a85 Mon Sep 17 00:00:00 2001 From: Eugen Cusmaunsa Date: Mon, 5 Jul 2021 12:26:52 +0100 Subject: [PATCH 4/5] Update CHANGELOG.rst --- CHANGELOG.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 7c7d343f26..6b993ad806 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -263,7 +263,7 @@ Changed * Update orquesta to v1.4.0. -* Reduced minimum TTL on garbage collection for action executions and trigger instances from 7 days to 1 day. +* Reduced minimum TTL on garbage collection for action executions and trigger instances from 7 days to 1 day. #5287 Contributed by @ericreeves. From ce29af70dec15c20db2a904196076bdbbcc4af52 Mon Sep 17 00:00:00 2001 From: Eugen Cusmaunsa Date: Mon, 5 Jul 2021 12:30:31 +0100 Subject: [PATCH 5/5] Move the changelog under the "In Development" section --- CHANGELOG.rst | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 7086446ae4..7e17b2b109 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -4,6 +4,12 @@ Changelog in development -------------- +Improvements +~~~~~~~~~~~~ +* Reduced minimum TTL on garbage collection for action executions and trigger instances from 7 days to 1 day. #5287 + + Contributed by @ericreeves. + 3.5.0 - June 23, 2021 --------------------- @@ -267,9 +273,6 @@ Changed * Update orquesta to v1.4.0. -* Reduced minimum TTL on garbage collection for action executions and trigger instances from 7 days to 1 day. #5287 - - Contributed by @ericreeves. Improvements ~~~~~~~~~~~~