From f80462f7aa0908a3ef59c73740b92775ca55d43b Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Fri, 9 Sep 2022 17:01:14 -0400 Subject: [PATCH 1/4] bump pants version to 2.14.0rc1 I used 2.14 for the PoC due to some features that simplify the pants configuration. Ideally, 2.14.0 final will be released in a month or so, while we finalize the st2 dev docs. This should be the final piece before we can run ./pants tailor. --- pants.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pants.toml b/pants.toml index c4a2eba651..53fd635145 100644 --- a/pants.toml +++ b/pants.toml @@ -1,5 +1,5 @@ [GLOBAL] -pants_version = "2.13.0rc2" +pants_version = "2.14.0rc1" backend_packages = [ # python "pants.backend.python", From 8f5e44bba131bc797720e7ff537441da019e00a4 Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Sun, 28 Mar 2021 17:58:44 -0500 Subject: [PATCH 2/4] Make pants ignore setup.py and dist_utils.py --- pants.toml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pants.toml b/pants.toml index 53fd635145..62354189d5 100644 --- a/pants.toml +++ b/pants.toml @@ -9,6 +9,12 @@ backend_packages = [ # shell "pants.backend.shell", ] +# pants ignores files in .gitignore, .*/ directories, /dist/ directory, and __pycache__. +pants_ignore.add = [ + # TODO: remove these once we start building wheels with pants. + "dist_utils.py", + "setup.py", +] [source] # recording each pack individually under root patterns is not great, but resolves these issues: From ab7a1d8ff2d45ffd9408b658a13a183947891b21 Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Thu, 26 May 2022 16:21:58 -0500 Subject: [PATCH 3/4] make pants tailor ignore python_requirements targets these requirements files will eventually be deleted. Including duplicate requirements definitions makes dependency inferrence ambiguous in pants, so we need to avoid adding duplicates. --- pants.toml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/pants.toml b/pants.toml index 62354189d5..5af7de45fa 100644 --- a/pants.toml +++ b/pants.toml @@ -14,6 +14,19 @@ pants_ignore.add = [ # TODO: remove these once we start building wheels with pants. "dist_utils.py", "setup.py", + # keep tailor from using legacy requirements files (not for pants) + "contrib/examples/requirements.txt", + "contrib/hello_st2/requirements.txt", + "contrib/runners/*/in-requirements.txt", + "contrib/runners/*/requirements.txt", + "st2*/in-requirements.txt", + "st2*/requirements.txt", + "st2common/tests/fixtures/requirements-used-for-tests.txt", + "/fixed-requirements.txt", + "/test-requirements.txt", + # keep requirements.txt for now. We might ignore it if we need an alternate interrim + # file that is decoupled from our legacy requirements files generation. + # "/requirements.txt", ] [source] From de76c96de4de9c3ada6535f3a36299797a3e8e33 Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Sat, 17 Sep 2022 00:44:01 -0600 Subject: [PATCH 4/4] update changelog entry --- CHANGELOG.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 9e081cf387..89876fc04f 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -53,7 +53,7 @@ Added * Begin introducing `pants `_ to improve DX (Developer Experience) working on StackStorm, improve our security posture, and improve CI reliability thanks in part - to pants' use of PEX lockfiles. This is not a user-facing addition. #5713 #5724 #5726 #5725 #5732 + to pants' use of PEX lockfiles. This is not a user-facing addition. #5713 #5724 #5726 #5725 #5732 #5733 Contributed by @cognifloyd Changed